Issue 87760044: implement resolveFn in bindToInstance

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87760044: implement resolveFn in bindToInstance (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rafaelw

Modified:
10 years, 1 month ago

Reviewers:
arv, rafaelw1

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

implement resolveFn in bindToInstance R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/cb17cbb

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -1 line)			Patch
	M	src/observe.js	View		2 chunks	+10 lines, -1 line	0 comments	Download
	M	tests/test.js	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as rcb17cbb (presubmit successful).

10 years, 1 month ago (2014-04-14 22:10:01 UTC) #1

rafaelw1

10 years, 1 month ago (2014-04-14 22:43:39 UTC) #3

+steve

Me neither =-). Actually, I'm just giving Steve a hard time. Polymer has
some DWIM which I find totally crazy, but they plan to keep. This callback
was mostly so that they can avoid forcing open the observable at the wrong
time to implement their DWIM.

On Mon, Apr 14, 2014 at 3:18 PM, <arv@chromium.org> wrote:

> LGTM
>
> I'm not sure what problem this solves though?
>
> https://codereview.appspot.com/87760044/
>

Expand All Messages | Collapse All Messages