Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 87730043: state/open.go: don't require "admin" access

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by jameinel
Modified:
10 years ago
Reviewers:
mp+215742, wallyworld
Visibility:
Public.

Description

state/open.go: don't require "admin" access When upgrading from 1.18, machine-0 doesn't have admin rights, and we haven't implemented bug #1306902 to give it right during upgrade. As such when machine-0 with 1.19 goes to log in, we shouldn't require logging into admin to succeed. We only need it to change replicaset data, so it shouldn't break anything (yet). One thing this patch doesn't try to do is record that logging in failed, so that if EnsureAvailability gets called we could refuse to do so if we don't have admin rights. https://code.launchpad.net/~jameinel/juju-core/soft-login-failure-1307450/+merge/215742 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/compat_test.go View 2 chunks +32 lines, -0 lines 0 comments Download
M state/open.go View 1 chunk +10 lines, -3 lines 0 comments Download
M state/state.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years ago (2014-04-14 19:35:19 UTC) #1
wallyworld
10 years ago (2014-04-14 22:51:33 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b