Issue 87560044: cmd/juju: destroy-environment api connect fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87560044: cmd/juju: destroy-environment api connect fix

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
dimitern, mp+215697

Visibility:
Public.

Description

cmd/juju: destroy-environment api connect fix destroy-environment was not using the .jenv file information to connect, which meant that it failed when destroying a HA environment, because we are not currently updating the environment-storage instance ids. https://code.launchpad.net/~rogpeppe/juju-core/548-destroy-environment-fix/+merge/215697 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: destroy-environment api connect fix #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -31 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/destroyenvironment.go	View	4 chunks	+28 lines, -30 lines	1 comment	Download
M	cmd/juju/status.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

10 years ago (2014-04-14 16:06:32 UTC) #2

LGTM

https://codereview.appspot.com/87560044/diff/20001/cmd/juju/destroyenvironmen...
File cmd/juju/destroyenvironment.go (right):

https://codereview.appspot.com/87560044/diff/20001/cmd/juju/destroyenvironmen...
cmd/juju/destroyenvironment.go:123: return fmt.Errorf("cannot connect to API:
%v", err)
s/API/API server/ ?

Expand All Messages | Collapse All Messages