Issue 8753044: openstack: pick flavor based on constraints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8753044: openstack: pick flavor based on constraints (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dimitern

Modified:
11 years ago

Reviewers:
mp+158889

Visibility:
Public.

Description

openstack: pick flavor based on constraints WIP, for discussion Not tested properly yet. https://code.launchpad.net/~dimitern/juju-core/033-openstack-pick-instance-type-based-on-constraints/+merge/158889 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -46 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/openstack/export_test.go	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	environs/openstack/image.go	View	1 chunk	+105 lines, -31 lines	2 comments	Download
M	environs/openstack/live_test.go	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	environs/openstack/provider.go	View	1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

Comments on implementation as agreed online. https://codereview.appspot.com/8753044/diff/1/environs/openstack/image.go File environs/openstack/image.go (right): https://codereview.appspot.com/8753044/diff/1/environs/openstack/image.go#newcode110 environs/openstack/image.go:110: if flavor.RAM >= ...

11 years ago (2013-04-17 12:26:41 UTC) #1

dimitern

11 years ago (2013-04-17 12:29:31 UTC) #2

Another comment

https://codereview.appspot.com/8753044/diff/1/environs/openstack/image.go
File environs/openstack/image.go (right):

https://codereview.appspot.com/8753044/diff/1/environs/openstack/image.go#new...
environs/openstack/image.go:75: allFlavors, err :=
novaClient.ListFlavorsDetail()
extract the logic below in a separate func, taking flavors list and default
flavor name, so it can be tested separately.

Expand All Messages | Collapse All Messages