code review 874041: cmath pkg

src/pkg/cmath/isinf.go

 // Copyright 2010 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package cmath
 
 import "math"
 
-// IsInf(x) returns true if either real(x) or imag(x) is an infinity.
+// IsInf returns true if either real(x) or imag(x) is an infinity.
 func IsInf(x complex128) bool {
-        // TODO(rsc) remove inlining whem compiler does it for us

[rsc1, 2010/04/02 07:13:53]

Not worth it in this one:

return math.IsInf(real(x), 0) || math.IsInf(imag(x), 0)

-        if real(x) < -math.MaxFloat64 || real(x) > math.MaxFloat64 || imag(x) < -math.MaxFloat64 || imag(x) > math.MaxFloat64 { // if math.IsInf(real(x), 0) || math.IsInf(imag(x), 0) {
+        if math.IsInf(real(x), 0) || math.IsInf(imag(x), 0) {
                 return true
         }
         return false
 }
 
-// Inf() returns a complex infinity.

[rsc1, 2010/04/02 07:13:53]

// Inf returns a complex infinity, cmplx(+Inf, +Inf).

+// Inf returns a complex infinity, cmplx(+Inf, +Inf).
 func Inf() complex128 {
         inf := math.Inf(1)
         return cmplx(inf, inf)
 }