go.tools/go/ssa: emit a recover block if the function's...

go/ssa/builder.go

Index: go/ssa/builder.go
===================================================================
--- a/go/ssa/builder.go
+++ b/go/ssa/builder.go
@@ -1912,14 +1912,12 @@
 		b.setCall(fn, s.Call, &v.Call)
 		fn.emit(&v)
 
-		// A deferred call can cause recovery from panic.
-		// If the panicking function has named results,
-		// control resumes at the Recover block to load those
-		// locals (which may be mutated by the deferred call)
-		// and return them.
-		if fn.namedResults != nil {
-			createRecoverBlock(fn)
-		}
+		// A deferred call can cause recovery from panic, and control
+		// resumes at the Recover block. If the panicking function

[adonovan, 2014/06/13 17:04:59]

You can delete the second and third sentences since createRecoverBlock explains
its behaviour.

+		// has named results, we load those locals (which may be
+		// mutated by the deferred call) and return them. Otherwise,
+		// we simply return zero values.
+		createRecoverBlock(fn)
 
 	case *ast.ReturnStmt:
 		var results []Value