Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 872048: code review 872048: godashboard: bz2 compress logs in data store (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by adg
Modified:
14 years, 11 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godashboard: bz2 compress logs in data store This results in a 10-20x size reduction per record. (from ~150kb to ~10kb) This revision has been pushed live, as I'm in the process of converting Log records to bz2-compresed CompressedLog records. I would have waited but we're running seriously low on space and it seemed like a sane (and reversible) move.

Patch Set 1 #

Patch Set 2 : code review 872048: godashboard: bz2 compress logs in data store #

Patch Set 3 : code review 872048: godashboard: bz2 compress logs in data store #

Patch Set 4 : code review 872048: godashboard: bz2 compress logs in data store #

Patch Set 5 : code review 872048: godashboard: bz2 compress logs in data store #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M misc/dashboard/godashboard/gobuild.py View 1 2 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-04-19 13:02:28 UTC) #1
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 11 months ago (2010-04-19 14:06:00 UTC) #2
adg
The conversion to the new data structure was successful. The Log model has been removed. ...
14 years, 11 months ago (2010-04-19 14:07:05 UTC) #3
rsc1
LGTM
14 years, 11 months ago (2010-04-19 14:26:03 UTC) #4
adg
14 years, 11 months ago (2010-04-19 23:07:05 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=a62b380e6aaf ***

godashboard: bz2 compress logs in data store

This results in a 10-20x size reduction per record.
(from ~150kb to ~10kb)

This revision has been pushed live, as I'm in the process of
converting Log records to bz2-compresed CompressedLog records.
I would have waited but we're running seriously low on space
and it seemed like a sane (and reversible) move.

R=rsc
CC=golang-dev
http://codereview.appspot.com/872048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b