code review 872041: json: use panic/recover to handle errors in Marshal

json: use panic/recover to handle errors in Marshal

[adg, 2010-04-01 00:00:04]

Hello r, gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-04-01 00:03:16]

LGTM but wait for rsc

On Wed, Mar 31, 2010 at 5:00 PM, <adg@golang.org> wrote:

> Reviewers: r, gri,
>
> Message:
> Hello r, gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> json: use panic/recover to handle errors in Marshal
>
> Please review this at http://codereview.appspot.com/872041/show
>
> Affected files:
>  M src/pkg/json/struct.go
>
>
>

[r, 2010-04-01 00:05:51]

http://codereview.appspot.com/872041/diff/2001/3001
File src/pkg/json/struct.go (right):

http://codereview.appspot.com/872041/diff/2001/3001#newcode462
src/pkg/json/struct.go:462: }
if it's not a *MarshalError, what should happen? you're dropping such things on
the floor.

[r, 2010-04-01 00:07:28]

http://codereview.appspot.com/872041/diff/2001/3001
File src/pkg/json/struct.go (right):

http://codereview.appspot.com/872041/diff/2001/3001#newcode462
src/pkg/json/struct.go:462: }
never mind, i see that it will panic.

[rsc1, 2010-04-01 00:16:48]

LGTM

with the simplified code the blank lines
are no longer necessary, and now it just
looks like the code is double-spaced.

http://codereview.appspot.com/872041/diff/2001/3001
File src/pkg/json/struct.go (right):

http://codereview.appspot.com/872041/diff/2001/3001#newcode354
src/pkg/json/struct.go:354: 
drop blank line here and two lines down

http://codereview.appspot.com/872041/diff/2001/3001#newcode396
src/pkg/json/struct.go:396: 
drop blank line here and two lines down and four lines down

[adg, 2010-04-01 00:19:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=dad56a994ab3 ***

json: use panic/recover to handle errors in Marshal

R=r, gri
CC=golang-dev
http://codereview.appspot.com/872041