Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(723)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 8709047: api samples: Update samples to 1.15.0-rc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by ngmiceli
Modified:
11 years, 11 months ago
Reviewers:
yanivi
Base URL:
https://code.google.com/p/google-api-java-client.samples/
Visibility:
Public.

Description

api samples: Update samples to 1.15.0-rc

Patch Set 1 #

Total comments: 4

Patch Set 2 : .classpath and warnings #

Total comments: 2

Patch Set 3 : Revert .prefs changes #

Patch Set 4 : Final 1.15.0-rc #

Patch Set 5 : android instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -142 lines) Patch
M adexchangebuyer-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M adexchangebuyer-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M adexchangebuyer-cmdline-sample/src/main/java/com/google/api/services/samples/adexchangebuyer/cmdline/AdExchangeBuyerSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M adsense-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M adsense-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M adsense-cmdline-sample/src/main/java/com/google/api/services/samples/adsense/cmdline/AdSenseSample.java View 2 chunks +3 lines, -3 lines 0 comments Download
M adsensehost-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M adsensehost-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M analytics-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M analytics-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/CoreReportingApiReferenceSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/HelloAnalyticsApiSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/ManagementApiReferenceSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/McfReportingApiReferenceSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M bigquery-appengine-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M bigquery-appengine-sample/pom.xml View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/DataServlet.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/MainServlet.java View 1 chunk +1 line, -0 lines 0 comments Download
M bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/SampleDashboardException.java View 1 chunk +2 lines, -0 lines 0 comments Download
M bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/ServiceUtils.java View 5 chunks +8 lines, -6 lines 0 comments Download
M bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/TaskServlet.java View 1 chunk +1 line, -0 lines 0 comments Download
M books-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M books-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M calendar-android-sample/instructions.html View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M calendar-android-sample/src/main/java/com/google/api/services/samples/calendar/android/CalendarSampleActivity.java View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M calendar-appengine-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M calendar-appengine-sample/pom.xml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M calendar-appengine-sample/src/main/java/com/google/api/services/samples/calendar/appengine/server/Utils.java View 2 chunks +3 lines, -2 lines 0 comments Download
M calendar-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M calendar-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M calendar-cmdline-sample/src/main/java/com/google/api/services/samples/calendar/cmdline/CalendarSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M compute-engine-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M compute-engine-cmdline-sample/pom.xml View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M compute-engine-cmdline-sample/src/main/java/com/google/api/services/samples/computeengine/cmdline/ComputeEngineSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M dfareporting-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M dfareporting-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M dfareporting-cmdline-sample/src/main/java/com/google/api/services/samples/dfareporting/cmdline/DfaReportingSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M discovery-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M discovery-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M discovery-cmdline-sample/src/main/java/com/google/api/services/samples/discovery/cmdline/DiscoverySample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M drive-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M drive-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M drive-cmdline-sample/src/main/java/com/google/api/services/samples/drive/cmdline/DriveSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M fusiontables-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M fusiontables-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java View 2 chunks +3 lines, -1 line 0 comments Download
M latitude-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M latitude-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M latitude-cmdline-sample/src/main/java/com/google/api/services/samples/latitude/cmdline/LatitudeSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M oauth2-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M oauth2-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M oauth2-cmdline-sample/src/main/java/com/google/api/services/samples/oauth2/cmdline/OAuth2Sample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M picasa-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M picasa-cmdline-sample/pom.xml View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PicasaSample.java View 1 2 chunks +3 lines, -2 lines 0 comments Download
M plus-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M plus-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M plus-preview-appengine-sample/pom.xml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M plus-preview-appengine-sample/src/main/java/com/google/api/services/samples/plus/Utils.java View 1 2 chunks +3 lines, -2 lines 0 comments Download
M plus-serviceaccount-cmdline-sample/.classpath View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M plus-serviceaccount-cmdline-sample/pom.xml View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M plus-serviceaccount-cmdline-sample/src/main/java/com/google/api/services/samples/plus/serviceaccount/cmdline/PlusServiceAccountSample.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M prediction-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M prediction-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M prediction-cmdline-sample/src/main/java/com/google/api/services/samples/prediction/cmdline/PredictionSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M shared/gdata/shared-sample-gdata/.classpath View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M shared/gdata/shared-sample-gdata/pom.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M shared/gdata/shared-sample-picasa/.classpath View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M siteVerification-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M siteVerification-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M siteVerification-cmdline-sample/src/main/java/com/google/api/services/samples/verification/cmdline/VerificationSample.java View 1 chunk +2 lines, -1 line 0 comments Download
M storage-serviceaccount-appengine-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M storage-serviceaccount-appengine-sample/pom.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M storage-serviceaccount-cmdline-sample/.classpath View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M storage-serviceaccount-cmdline-sample/pom.xml View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M storage-serviceaccount-cmdline-sample/src/main/java/com/google/api/services/samples/storage/serviceaccount/cmdline/StorageServiceAccountSample.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M taskqueue-cmdline-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M taskqueue-cmdline-sample/pom.xml View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M taskqueue-cmdline-sample/src/main/java/com/google/api/services/samples/taskqueue/cmdline/TaskQueueSample.java View 2 chunks +3 lines, -2 lines 0 comments Download
M tasks-android-sample/instructions.html View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M urlshortener-robots-appengine-sample/.classpath View 1 1 chunk +1 line, -1 line 0 comments Download
M urlshortener-robots-appengine-sample/pom.xml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8
yanivi
Please fix these Eclipse warnings: Description Resource Path Location Type The method setServiceAccountScopes(String...) from the ...
11 years, 11 months ago (2013-05-04 12:33:14 UTC) #1
yanivi
Some more: Description Resource Path Location Type The method load(JsonFactory, InputStream) from the type GoogleClientSecrets ...
11 years, 11 months ago (2013-05-04 12:35:35 UTC) #2
ngmiceli
Handled the reported warnings as well. The one for plus-preview-appengine-sample I don't have, nor should ...
11 years, 11 months ago (2013-05-06 20:41:30 UTC) #3
yanivi
https://codereview.appspot.com/8709047/diff/16001/plus-preview-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs File plus-preview-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs (right): https://codereview.appspot.com/8709047/diff/16001/plus-preview-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs#newcode2 plus-preview-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs:2: filesCopiedToWebInfLib=appengine-api-1.0-sdk-1.7.3.jar|appengine-api-labs.jar|appengine-endpoints.jar|appengine-jsr107cache-1.7.3.jar|datanucleus-appengine-1.0.10.final.jar|datanucleus-core-1.1.5.jar|datanucleus-jpa-1.1.5.jar|geronimo-jpa_3.0_spec-1.1.1.jar|geronimo-jta_1.1_spec-1.1.1.jar|jdo2-api-2.3-eb.jar|jsr107cache-1.1.jar please revert this change. we should be on ...
11 years, 11 months ago (2013-05-07 15:07:06 UTC) #4
ngmiceli
On 2013/05/07 15:07:06, yanivi wrote: > https://codereview.appspot.com/8709047/diff/16001/plus-preview-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs > File > plus-preview-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs > (right): > > ...
11 years, 11 months ago (2013-05-07 15:14:14 UTC) #5
yanivi
Good. Waiting for final 1.15.0-rc to be released before updating Android samples.
11 years, 11 months ago (2013-05-07 15:17:45 UTC) #6
ngmiceli
Updating to final 1.15.0-rc. PTAL
11 years, 11 months ago (2013-05-10 20:06:33 UTC) #7
yanivi
11 years, 11 months ago (2013-05-10 20:30:18 UTC) #8 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b