Issue 87065: Make any object throwable in Valija. Addresses issue 1036.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87065: Make any object throwable in Valija. Addresses issue 1036. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by metaweta

Modified:
16 years, 10 months ago

Reviewers:
MarkM

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added a table to $v for storing exceptions. Stores the object on throw, retrieves it on catch.

Patch Set 1 #

Patch Set 2 : Make any object throwable in Valija. Addresses issue 1036. #

Total comments: 4

Patch Set 3 : Make any object throwable in Valija. Addresses issue 1036. #

Patch Set 4 : Make any object throwable in Valija. Addresses issue 1036. #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -8 lines)			Patch
M	src/com/google/caja/cajita.js	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/quasiliteral/CajitaRewriter.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java	View	1 2	3 chunks	+21 lines, -4 lines	0 comments	Download
M	src/com/google/caja/parser/quasiliteral/PermitTemplate.java	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	src/com/google/caja/valija-cajita.js	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MarkM

16 years, 11 months ago (2009-06-25 22:02:16 UTC) #2

Modulo 3 minor issues and one bug, LGTM.

http://codereview.appspot.com/87065/diff/15/1003
File src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java (right):

http://codereview.appspot.com/87065/diff/15/1003#newcode652
Line 652: Map<String, ParseTreeNode> bindings = match(node);
The body of this function should be simplified to

    return transform(node, scope, mq);

http://codereview.appspot.com/87065/diff/15/1006
File src/com/google/caja/valija-cajita.js (right):

http://codereview.appspot.com/87065/diff/15/1006#newcode473
Line 473: * object between vats, which is as it should be.
I don't think we've been generally using the "vat" terminology here. Change this
to something like "Valija sandbox".

(Besides, "vat" is wrong anyway since the caller and callee would be
synchronously coupled.)

http://codereview.appspot.com/87065/diff/15/1006#newcode476
Line 476: var pumpkin = {};
Please rename your "pumpkin". There is already another "pumpkin" defined in the
same scope for a similar but different use.

http://codereview.appspot.com/87065/diff/15/1006#newcode484
Line 484: function exceptionTableRead(key) {
Please do file an issue on the remaining memory leak problem.

Expand All Messages | Collapse All Messages