Issue 8706044: python password strength classifier

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8706044: python password strength classifier

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by Thomas.J.Waldmann

Modified:
11 years ago

Reviewers:

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : improved #

Total comments: 2

Patch Set 3 : make classifications a parameter and a table rather than hardcode it #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -0 lines)			Patch
	M	entropy.py	View	1 2	1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

11 years ago (2013-04-28 12:09:43 UTC) #1

https://codereview.appspot.com/8706044/diff/1/entropy.py
File entropy.py (right):

https://codereview.appspot.com/8706044/diff/1/entropy.py#newcode75
entropy.py:75: """
copyright: 2013 Thomas Waldmann
license: same as passlib

https://codereview.appspot.com/8706044/diff/2001/entropy.py
File entropy.py (right):

https://codereview.appspot.com/8706044/diff/2001/entropy.py#newcode1
entropy.py:1: """
filename will also be changed later...

https://codereview.appspot.com/8706044/diff/2001/entropy.py#newcode24
entropy.py:24: def strength(symbols, weak_limit=10, strong_limit=20):
todo: rename strong_limit to maybe_weak_limit to be more consistent and to not
suggest that everything above is considered strong.

Expand All Messages | Collapse All Messages