Fix a collection of Domita-related bugs

Fix the following issues:
http://code.google.com/p/google-caja/issues/detail?id=1034
http://code.google.com/p/google-caja/issues/detail?id=1047
http://code.google.com/p/google-caja/issues/detail?id=1048
http://code.google.com/p/google-caja/issues/detail?id=1051

[ihab.awad, 2009-06-25 05:27:21]

Mike, please go ahead and review Patch set 2. Thanks!

[metaweta, 2009-06-25 21:15:11]

lgtm

http://codereview.appspot.com/87058/diff/16/28
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/87058/diff/16/28#newcode567
Line 567: throw "Domita assertion failed";
throw new Error("Domita assertion failed");

http://codereview.appspot.com/87058/diff/16/28#newcode1985
Line 1985: if (!listener) {  // Clear the current handler
Here you check if it's falsey, but you assume later that it's callable.  You
should probably check that listener is a (dis)function.

On the other hand, on FF3, you can set the onclick property of a div element to
0.  Do we care about supporting that?

http://codereview.appspot.com/87058/diff/16/28#newcode3482
Line 3482: ___.asFunc(___.readPub(aListener, 'call'))
What is aListener?

[ihab.awad, 2009-06-29 22:46:26]

http://codereview.appspot.com/87058/diff/16/28
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/87058/diff/16/28#newcode1985
Line 1985: if (!listener) {  // Clear the current handler
On 2009/06/25 21:15:11, metaweta wrote:
> Here you check if it's falsey, but you assume later that it's callable.  You
> should probably check that listener is a (dis)function.

Good point. It is checked in makeEventHandlerWrapper(...). I consolidated that
checking code in classUtils and used it from the 2 places where it's needed.

> On the other hand, on FF3, you can set the onclick property of a div element
to
> 0.  Do we care about supporting that?

You mean programmatically setting it to a non-function? That sounds nonstandard,
so I'd say we should skip this unless and until we know that skipping it breaks
some important usage.

http://codereview.appspot.com/87058/diff/16/28#newcode3482
Line 3482: ___.asFunc(___.readPub(aListener, 'call'))
On 2009/06/25 21:15:11, metaweta wrote:
> What is aListener?

Zoikes, you found a bug! :) Fixed and added a test in domita_test_untrusted.html
"testAddEventListener".

[ihab.awad, 2009-06-29 22:50:21]

http://codereview.appspot.com/87058/diff/16/28
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/87058/diff/16/28#newcode567
Line 567: throw "Domita assertion failed";
On 2009/06/25 21:15:11, metaweta wrote:
> throw new Error("Domita assertion failed");

Done.

[metaweta, 2009-06-29 23:03:22]

lgtm

http://codereview.appspot.com/87058/diff/2020/3036
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/87058/diff/2020/3036#newcode537
Line 537: expectFailure(
whitespace

[ihab.awad, 2009-06-29 23:07:03]

http://codereview.appspot.com/87058/diff/2020/3036
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/87058/diff/2020/3036#newcode537
Line 537: expectFailure(
On 2009/06/29 23:03:22, metaweta wrote:
> whitespace

Done.

[ihab.awad, 2009-06-29 23:08:04]

@3548