Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1751)

Issue 87043: underwater acoustic device

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Tom Henderson
Modified:
11 years, 10 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 108
Unified diffs Side-by-side diffs Delta from patch set Stats (+36257 lines, -0 lines) Patch
A examples/dat/105-10000.dat View 1 chunk +1694 lines, -0 lines 2 comments Download
A examples/dat/115-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/125-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/135-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/15-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/25-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/35-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/45-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/5-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/55-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/65-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/75-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/85-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/95-10000.dat View 1 chunk +1694 lines, -0 lines 0 comments Download
A examples/dat/default.cfg View 1 chunk +66 lines, -0 lines 0 comments Download
A examples/uan-create-dat.cc View 1 chunk +950 lines, -0 lines 7 comments Download
A examples/uan-cw-example.cc View 1 chunk +325 lines, -0 lines 11 comments Download
A examples/uan-dat-read.cc View 1 chunk +69 lines, -0 lines 2 comments Download
A examples/uan-rc-example.cc View 1 chunk +331 lines, -0 lines 4 comments Download
M examples/wscript View 1 chunk +13 lines, -0 lines 1 comment Download
A src/devices/uan/uan.h View 1 chunk +158 lines, -0 lines 1 comment Download
A src/devices/uan/uan-address.h View 1 chunk +102 lines, -0 lines 0 comments Download
A src/devices/uan/uan-address.cc View 1 chunk +140 lines, -0 lines 6 comments Download
A src/devices/uan/uan-channel.h View 1 chunk +110 lines, -0 lines 0 comments Download
A src/devices/uan/uan-channel.cc View 1 chunk +191 lines, -0 lines 5 comments Download
A src/devices/uan/uan-header-common.h View 1 chunk +95 lines, -0 lines 1 comment Download
A src/devices/uan/uan-header-common.cc View 1 chunk +133 lines, -0 lines 2 comments Download
A src/devices/uan/uan-header-rc.h View 1 chunk +370 lines, -0 lines 0 comments Download
A src/devices/uan/uan-header-rc.cc View 1 chunk +628 lines, -0 lines 13 comments Download
A src/devices/uan/uan-mac.h View 1 chunk +96 lines, -0 lines 0 comments Download
A src/devices/uan/uan-mac-aloha.h View 1 chunk +86 lines, -0 lines 0 comments Download
A src/devices/uan/uan-mac-aloha.cc View 1 chunk +139 lines, -0 lines 1 comment Download
A src/devices/uan/uan-mac-cw.h View 1 chunk +120 lines, -0 lines 0 comments Download
A src/devices/uan/uan-mac-cw.cc View 1 chunk +361 lines, -0 lines 2 comments Download
A src/devices/uan/uan-mac-rc.h View 1 chunk +172 lines, -0 lines 1 comment Download
A src/devices/uan/uan-mac-rc.cc View 1 chunk +731 lines, -0 lines 2 comments Download
A src/devices/uan/uan-mac-rc-gw.h View 1 chunk +164 lines, -0 lines 0 comments Download
A src/devices/uan/uan-mac-rc-gw.cc View 1 chunk +723 lines, -0 lines 7 comments Download
A src/devices/uan/uan-net-device.h View 1 chunk +142 lines, -0 lines 0 comments Download
A src/devices/uan/uan-net-device.cc View 1 chunk +374 lines, -0 lines 2 comments Download
A src/devices/uan/uan-noise-model.h View 1 chunk +44 lines, -0 lines 0 comments Download
A src/devices/uan/uan-noise-model-default.h View 1 chunk +66 lines, -0 lines 1 comment Download
A src/devices/uan/uan-noise-model-default.cc View 1 chunk +84 lines, -0 lines 1 comment Download
A src/devices/uan/uan-phy.h View 1 chunk +302 lines, -0 lines 3 comments Download
A src/devices/uan/uan-phy-dual.h View 1 chunk +228 lines, -0 lines 2 comments Download
A src/devices/uan/uan-phy-dual.cc View 1 chunk +626 lines, -0 lines 2 comments Download
A src/devices/uan/uan-phy-gen.h View 1 chunk +226 lines, -0 lines 6 comments Download
A src/devices/uan/uan-phy-gen.cc View 1 chunk +844 lines, -0 lines 9 comments Download
A src/devices/uan/uan-prop-model.h View 1 chunk +150 lines, -0 lines 1 comment Download
A src/devices/uan/uan-prop-model.cc View 1 chunk +307 lines, -0 lines 1 comment Download
A src/devices/uan/uan-prop-model-bh.h View 1 chunk +203 lines, -0 lines 1 comment Download
A src/devices/uan/uan-prop-model-bh.cc View 1 chunk +632 lines, -0 lines 3 comments Download
A src/devices/uan/uan-prop-model-ideal.h View 1 chunk +54 lines, -0 lines 0 comments Download
A src/devices/uan/uan-prop-model-ideal.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A src/devices/uan/uan-prop-model-thorp.h View 1 chunk +58 lines, -0 lines 0 comments Download
A src/devices/uan/uan-prop-model-thorp.cc View 1 chunk +102 lines, -0 lines 1 comment Download
A src/devices/uan/uan-test.cc View 1 chunk +283 lines, -0 lines 2 comments Download
A src/devices/uan/uan-transducer.h View 1 chunk +154 lines, -0 lines 1 comment Download
A src/devices/uan/uan-transducer-hd.h View 1 chunk +74 lines, -0 lines 1 comment Download
A src/devices/uan/uan-transducer-hd.cc View 1 chunk +216 lines, -0 lines 0 comments Download
A src/devices/uan/uan-tx-mode.h View 1 chunk +166 lines, -0 lines 1 comment Download
A src/devices/uan/uan-tx-mode.cc View 1 chunk +321 lines, -0 lines 0 comments Download
A src/devices/uan/wscript View 1 chunk +53 lines, -0 lines 0 comments Download
A src/helper/uan-helper.h View 1 chunk +256 lines, -0 lines 1 comment Download
A src/helper/uan-helper.cc View 1 chunk +229 lines, -0 lines 1 comment Download
M src/helper/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/wscript View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
craigdo1
Mostly nits and doxygen requests. I think this needs to go in its own examples ...
12 years, 2 months ago (2009-07-11 00:10:52 UTC) #1
faker.moatamri
A review of the code. http://codereview.appspot.com/87043/diff/1/2 File examples/dat/105-10000.dat (right): http://codereview.appspot.com/87043/diff/1/2#newcode1 Line 1: rd 5 I ...
11 years, 11 months ago (2009-10-21 10:24:09 UTC) #2
Andrey Mazo
11 years, 10 months ago (2009-11-15 13:32:11 UTC) #3
http://codereview.appspot.com/87043/diff/1/1016
File examples/uan-create-dat.cc (right):

http://codereview.appspot.com/87043/diff/1/1016#newcode8
examples/uan-create-dat.cc:8: * (at your option) any later version.
ns-3 is licensed under GPLv2.

http://codereview.appspot.com/87043/diff/1/18
File examples/uan-cw-example.cc (right):

http://codereview.appspot.com/87043/diff/1/18#newcode113
examples/uan-cw-example.cc:113: for (uint32_t i=0;i<m_avgs;i++)
coding style

http://codereview.appspot.com/87043/diff/1/18#newcode119
examples/uan-cw-example.cc:119: m_throughputs.clear();
again, coding style

http://codereview.appspot.com/87043/diff/1/18#newcode183
examples/uan-cw-example.cc:183: ;
orphaned ";"?

http://codereview.appspot.com/87043/diff/1/1018
File examples/uan-dat-read.cc (right):

http://codereview.appspot.com/87043/diff/1/1018#newcode54
examples/uan-dat-read.cc:54: cmd.AddValue("Freq", "Frequency", freq);
coding style

http://codereview.appspot.com/87043/diff/1/1021
File examples/wscript (right):

http://codereview.appspot.com/87043/diff/1/1021#newcode178
examples/wscript:178: objcd2.source = 'uan-dat-read.cc'
maybe use just "obj" instead of "objcw", "objrc", etc for consistency.

http://codereview.appspot.com/87043/diff/1/1022
File src/devices/uan/uan-address.cc (right):

http://codereview.appspot.com/87043/diff/1/1022#newcode32
src/devices/uan/uan-address.cc:32: }
UanAddress::UanAddress () :
  m_address (255)
{
}

http://codereview.appspot.com/87043/diff/1/1024
File src/devices/uan/uan-channel.cc (right):

http://codereview.appspot.com/87043/diff/1/1024#newcode76
src/devices/uan/uan-channel.cc:76: {
On 2009/07/11 00:10:52, craigdo1 wrote:
> m_prop and m_noise are Ptr<> ... where are they released?
It's a part of another discussion (bug 721).

http://codereview.appspot.com/87043/diff/1/1024#newcode134
src/devices/uan/uan-channel.cc:134: int j = 0;
Should be uint32_t, as SendUp (uint32_t, Ptr<Packet>, ...)

http://codereview.appspot.com/87043/diff/1/26
File src/devices/uan/uan-mac-aloha.cc (right):

http://codereview.appspot.com/87043/diff/1/26#newcode42
src/devices/uan/uan-mac-aloha.cc:42: NS_LOG_DEBUG ("Assigned address " <<
m_address);
Are you trying to print initialized variable?

http://codereview.appspot.com/87043/diff/1/1033
File src/devices/uan/uan-mac-cw.cc (right):

http://codereview.appspot.com/87043/diff/1/1033#newcode344
src/devices/uan/uan-mac-cw.cc:344: }
if{} else{} coding style

http://codereview.appspot.com/87043/diff/1/1034
File src/devices/uan/uan-mac-rc-gw.cc (right):

http://codereview.appspot.com/87043/diff/1/1034#newcode690
src/devices/uan/uan-mac-rc-gw.cc:690: k = n-k;
coding style

http://codereview.appspot.com/87043/diff/1/36
File src/devices/uan/uan-mac-rc.cc (right):

http://codereview.appspot.com/87043/diff/1/36#newcode47
src/devices/uan/uan-mac-rc.cc:47: uint32_t m_cntrlSends=0;
Why not to make it UanMacRc private static variable?

http://codereview.appspot.com/87043/diff/1/1042
File src/devices/uan/uan-phy-dual.cc (right):

http://codereview.appspot.com/87043/diff/1/1042#newcode98
src/devices/uan/uan-phy-dual.cc:98: NS_LOG_DEBUG ("Adding interferer from " <<
ch2.GetSrc () << " against " << ch.GetSrc () << ": PktRxMode: " << mode.GetName
() << " Int mode: " << it->GetTxMode ().GetName () << " Separation: " <<
std::abs ( (double) it->GetTxMode ().GetCenterFreqHz () - (double)
mode.GetCenterFreqHz ()) << " Combined bandwidths: " << (double) (it->GetTxMode
().GetBandwidthHz ()/2 + mode.GetBandwidthHz ()/2) - 0.5);
very long line
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b