Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1950)

Issue 87010044: cert: use strings not []byte

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rog
Modified:
10 years ago
Reviewers:
natefinch, mp+215478
Visibility:
Public.

Description

cert: use strings not []byte This resolves a current ambivalence between whether we store certificates and keys a string or []byte. The external format used by x509 and friends is []byte, but it's overwhelmingly more convenient for us to use string throughout. https://code.launchpad.net/~rogpeppe/juju-core/545-cert-string/+merge/215478 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cert: use strings not []byte #

Patch Set 3 : cert: use strings not []byte #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -222 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent.go View 4 chunks +5 lines, -8 lines 0 comments Download
M agent/agent_test.go View 10 chunks +10 lines, -10 lines 0 comments Download
M agent/bootstrap_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M agent/format-1.16.go View 1 chunk +1 line, -1 line 0 comments Download
M agent/format-1.18.go View 1 chunk +1 line, -1 line 0 comments Download
M agent/format_whitebox_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cert/cert.go View 6 chunks +27 lines, -26 lines 0 comments Download
M cert/cert_test.go View 7 chunks +11 lines, -11 lines 0 comments Download
M cmd/jujud/bootstrap_test.go View 7 chunks +7 lines, -7 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 9 chunks +18 lines, -18 lines 0 comments Download
M environs/cloudinit_test.go View 3 chunks +10 lines, -10 lines 0 comments Download
M environs/config/authkeys.go View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M environs/config/config.go View 3 chunks +12 lines, -12 lines 0 comments Download
M environs/config/config_test.go View 1 chunk +7 lines, -7 lines 0 comments Download
M environs/httpstorage/backend.go View 1 chunk +3 lines, -3 lines 0 comments Download
M environs/httpstorage/backend_test.go View 1 chunk +8 lines, -3 lines 0 comments Download
M environs/httpstorage/storage.go View 1 chunk +3 lines, -5 lines 0 comments Download
M environs/httpstorage/storage_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M juju/api.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/conn.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/instance.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/azure/customdata_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/azure/environ_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/dummy/environs.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/manual/environ.go View 1 chunk +8 lines, -8 lines 0 comments Download
M state/api/apiclient.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/common/apiaddresser.go View 1 chunk +3 lines, -3 lines 0 comments Download
M state/api/rsyslog/rsyslog.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/api/testing/apiaddresser.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/common/addresses.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/common/addresses_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/apiserver/deployer/deployer_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/login_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/provisioner/provisioner_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/rsyslog/rsyslog.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/rsyslog/rsyslog_test.go View 2 chunks +10 lines, -10 lines 0 comments Download
M state/apiserver/server_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/open.go View 2 chunks +3 lines, -3 lines 0 comments Download
M state/settings_test.go View 1 chunk +1 line, -1 line 0 comments Download
M testing/cert.go View 4 chunks +5 lines, -5 lines 0 comments Download
M testing/mgo.go View 1 chunk +1 line, -1 line 0 comments Download
M upgrades/agentconfig_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/deployer/simple_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/localstorage/config.go View 4 chunks +10 lines, -10 lines 0 comments Download
M worker/localstorage/config_test.go View 2 chunks +6 lines, -6 lines 0 comments Download
M worker/provisioner/kvm-broker_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/rsyslog/rsyslog_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/rsyslog/worker.go View 4 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
10 years ago (2014-04-11 18:28:39 UTC) #1
natefinch
10 years ago (2014-04-11 18:35:15 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b