Issue 86930046: fix upgrade from 1.18 to 1.19

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86930046: fix upgrade from 1.18 to 1.19

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by natefinch

Modified:
10 years, 10 months ago

Reviewers:
mp+215504, jameinel, wallyworld

Visibility:
Public.

Description

fix upgrade from 1.18 to 1.19 So, we can't start old mongo servers into replset mode just yet, which was causing the problem. So for now, we won't replace the old upstart scripts of existing servers. https://code.launchpad.net/~natefinch/juju-core/042-sortaensure/+merge/215504 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/mongo/mongo.go	View	3 chunks	+11 lines, -2 lines	1 comment	Download
M	agent/mongo/mongo_test.go	View	2 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

wallyworld

LGTM with another TODO added https://codereview.appspot.com/86930046/diff/1/agent/mongo/mongo.go File agent/mongo/mongo.go (right): https://codereview.appspot.com/86930046/diff/1/agent/mongo/mongo.go#newcode231 agent/mongo/mongo.go:231: if os.IsExist(err) { Can ...

10 years, 10 months ago (2014-04-11 21:58:04 UTC) #2

jameinel

10 years, 10 months ago (2014-04-12 05:29:43 UTC) #3

Just to be clear, the "We can't upgrade" is because we have to do the
mongo-single-user song-and-dance to get API servers admin rights to be able to
configure the replica set details, is that correct?

If so, LGTM

Expand All Messages | Collapse All Messages