Issue 86800043: Isolate ssh tests with FakeHomeSuite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86800043: Isolate ssh tests with FakeHomeSuite

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by waigani

Modified:
10 years ago

Reviewers:
mp+215382, dave

Visibility:
Public.

Description

Isolate ssh tests with FakeHomeSuite Use the FakeHomeSuite to isolate provider/common tests which require ssh keys. https://code.launchpad.net/~waigani/juju-core/1299969-isolate-more-ssh-tests/+merge/215382 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/common/bootstrap_test.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	provider/common/supportedarchitectures_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years ago (2014-04-11 10:28:19 UTC) #2

LGTM. Ship it

$ go test ./provider/common/
ok      launchpad.net/juju-core/provider/common 24.926s

Expand All Messages | Collapse All Messages