Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3047)

Issue 8677044: Do not call GetAdapterDisplayMode after Display has been initialized. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by apatrick1
Modified:
11 years ago
Reviewers:
shannon.woods, nicolas, nicolas%transgaming.com
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Do not call GetAdapterDisplayMode after Display has been initialized. Some AMD drivers fail with D3DERR_NOTAVAILABLE after the machine has been in sleep mode and never seem to recover for a given IDirect3D9 object. I reproduced with Catalyst 9.12.0.0 and a Radeon 7700. Instead, record the display mode at the time the it was initialized and thereafter use its format as the argument to CheckDeviceFormat etc. Previously, CheckDeviceFormat was passed an uninitialized value as the format if GetAdapterDisplayMode failed. See http://crbug.com/229950 Committed: https://code.google.com/p/angleproject/source/detail?r=2183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -53 lines) Patch
M src/libEGL/Display.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libEGL/Display.cpp View 10 chunks +31 lines, -53 lines 0 comments Download

Messages

Total messages: 3
apatrick1
Please review, Thanks.
11 years ago (2013-04-16 21:20:44 UTC) #1
nicolas%transgaming.com
Looks good to me. FYI note that in the dx11proto branch we moved all the ...
11 years ago (2013-04-17 05:05:11 UTC) #2
apatrick1
11 years ago (2013-04-17 19:18:26 UTC) #3
I think dx11proto will not have this issue then and this won't need merging.
I'll verify.

I'll maybe make dx11proto check the result of GetAdapterDisplayMode though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b