Refactoring Domado: bundle nodeClasses/inertCtor into an object.

Put nodeClasses and nodeTamers tables into an object to manage their
state transitions and consistency.

This is intended to make load order dependencies more visible and
fail-stop, make further refactoring easier, and prepare for future reuse
(e.g. taming setTimeout and XMLHttpRequest without an associated DOM).

@r5354

[kpreid2, 2013-04-11 19:21:39]

Put nodeClasses and nodeTamers tables into an object to manage their
state transitions and consistency.

This is intended to make load order dependencies more visible and
fail-stop, make further refactoring easier, and prepare for future reuse
(e.g. taming setTimeout and XMLHttpRequest without an associated DOM).

[felix8a, 2013-04-14 20:57:37]

lgtm

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:1157:
prototypeNames.set(safeCtor.prototype, name);
it feels odd that this set is conditional, but I can't think of a simpler
alternative, so ok.

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:1160: this.registerSafeCtor =
registerSafeCtor;
any reason this is a separate statement unlike the other functions?

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:1173: this.exportTo = function
exportTo(imports) {
maybe add a paranoia check, abort here if safeCtors isn't frozen?

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:2687: if ((specificTamer =
how about move this assignment out of the if?

[kpreid2, 2013-04-15 18:36:04]

Put nodeClasses and nodeTamers tables into an object to manage their
state transitions and consistency.

This is intended to make load order dependencies more visible and
fail-stop, make further refactoring easier, and prepare for future reuse
(e.g. taming setTimeout and XMLHttpRequest without an associated DOM).

[kpreid2, 2013-04-15 18:36:21]

Put nodeClasses and nodeTamers tables into an object to manage their
state transitions and consistency.

This is intended to make load order dependencies more visible and
fail-stop, make further refactoring easier, and prepare for future reuse
(e.g. taming setTimeout and XMLHttpRequest without an associated DOM).

[kpreid2, 2013-04-15 18:36:26]

Going to submit since you said LGTM; changes as noted below.

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:1157:
prototypeNames.set(safeCtor.prototype, name);
On 2013/04/14 20:57:37, felix8a wrote:
> it feels odd that this set is conditional, but I can't think of a simpler
> alternative, so ok.

There are two cases where a class is given two names, and we want to use the
first one (HTMLElement vs. Element, HTMLDocument vs. Document). Those are
technically incorrect; I just haven't bothered adding a mostly-useless
additional prototype. If I ever do, this can become a hard failure instead.
Added comments.

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:1160: this.registerSafeCtor =
registerSafeCtor;
On 2013/04/14 20:57:37, felix8a wrote:
> any reason this is a separate statement unlike the other functions?

Obsolete reason: a previous version used registerSafeCtor inside of inertCtor.
Changed.

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:1173: this.exportTo = function
exportTo(imports) {
On 2013/04/14 20:57:37, felix8a wrote:
> maybe add a paranoia check, abort here if safeCtors isn't frozen?

Done.

https://codereview.appspot.com/8676043/diff/2001/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domado.js:2687: if ((specificTamer =
On 2013/04/14 20:57:37, felix8a wrote:
> how about move this assignment out of the if?

I like having the details of the lookup inside the conditional, but it's
particularly ugly here, yes.

Done.