Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 867041: support AF_NETLINK in src/process-manager

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Hajime Tazaki
Modified:
12 years, 4 months ago
Reviewers:
Mathieu Lacage
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This changeset is created agiainst the patch in Issue 717042 for ns-3-simu. Issue 717042: http://codereview.appspot.com/717042/show The patch aims to support netlink socket (AF_NETLINK) in src/process-manager. It will be used for quagga support in ns-3 in the future. During the modification and satisfy test.py, we modified several existing IPv4 code and class Node. Modified source codes are as follows. src/internet-stack/ipv4-raw-socket-impl.cc src/internet-stack/udp-socket-impl.cc src/internet-stack/wscript src/node/node.cc I've raised the question in ns-developer ML about the modification for class Node. And in original test-stdio.cc, it calls fcloseall (), which close all the descriptor. But after this testcase, we cannot use stdio any more. I've just commented out this call since I couldn't get the point of this reason. This should be updated when we merge code.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update with Mathieu's comments #

Patch Set 3 : CreateStack with ScheduledContext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -40 lines) Patch
M .hgignore View 1 chunk +7 lines, -1 line 0 comments Download
M src/process-manager/process-manager-test.cc View 1 2 6 chunks +64 lines, -10 lines 0 comments Download
M src/process-manager/simu-fd.cc View 3 chunks +51 lines, -21 lines 0 comments Download
A src/process-manager/tests/test-socket.cc View 1 1 chunk +344 lines, -0 lines 0 comments Download
M src/process-manager/tests/wscript View 1 chunk +1 line, -0 lines 0 comments Download
M src/process-manager/unix-datagram-socket-fd.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/process-manager/unix-socket-fd.cc View 4 chunks +36 lines, -8 lines 0 comments Download
M wscript View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Hajime Tazaki
Hello Mathieu, all, I've created new issue for the review, which is for merging to ...
12 years, 6 months ago (2010-03-31 05:41:45 UTC) #1
Mathieu Lacage
My main comment is that I really would like to see the src/node/internet-stack changes be ...
12 years, 6 months ago (2010-04-02 11:38:07 UTC) #2
Hajime Tazaki
On 2010/04/02 11:38:07, Mathieu Lacage wrote: > My main comment is that I really would ...
12 years, 6 months ago (2010-04-02 15:22:05 UTC) #3
Mathieu Lacage
On Fri, Apr 2, 2010 at 5:22 PM, <thehajime@gmail.com> wrote: >> http://codereview.appspot.com/867041/diff/1/12 >> File src/process-manager/unix-datagram-socket-fd.cc ...
12 years, 6 months ago (2010-04-06 09:31:36 UTC) #4
Hajime Tazaki
On 2010/04/02 11:38:07, Mathieu Lacage wrote: > http://codereview.appspot.com/867041/diff/1/6 > File src/node/node.cc (right): > > http://codereview.appspot.com/867041/diff/1/6#newcode273 ...
12 years, 6 months ago (2010-04-06 16:07:37 UTC) #5
Hajime Tazaki
At Tue, 6 Apr 2010 11:31:33 +0200, Mathieu Lacage wrote: > >On Fri, Apr 2, ...
12 years, 6 months ago (2010-04-07 07:32:08 UTC) #6
Hajime Tazaki
12 years, 4 months ago (2010-06-04 03:46:39 UTC) #7
On 2010/04/07 07:32:08, Hajime Tazaki wrote:

> The followings are the summary of behavior: the returned
> value of send/recv system call of raw socket in Linux and
> current ns-3.
> 
> 
>            | IP_HDRINC on  |      off    |
> -----------+---------------+-------------+-
>     Ipv4 Tx| payload + hdr | payload     |
>     Ipv4 Rx| payload + hdr | payload+hdr |
> ns3 Ipv4 Tx|     X         | payload+hdr |  * (I guess ns-3 doesn't have
> capability of IP_HDRINCL)
> ns3 Ipv4 Rx|     X         | payload+hdr |
>     Ipv6 Tx|     X         | payload     |  * (IPv6 ns-3 doesn't have
capability
> of IP_HDRINCL)
>     Ipv6 Rx|     X         | payload     |  * (IPv6 ns-3 doesn't have
capability
> of IP_HDRINCL)
> ns3 Ipv6 Tx|     X         | payload+hdr?|  (not confirmed yet)
> ns3 Ipv6 Rx|     X         | payload+hdr?|  (not confirmed yet)
> 
> If we will follow Linux implementation, we should modify
> ns-3 at least:
>  - return value of Ipv4RawSocketImpl::SendTo ()
>  - IP_HDRINCL support in Ipv4RawSocketImpl::SendTo ()

changeset 6334	c9373f264dfe
changeset 6336	464e8093700d

includes Ipv4 IP_HDRINCL support.
Ipv6 support is not included, will catch up soon.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b