Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 8666044: Add permessage-deflate support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by tyoshino (chromium.org)
Modified:
12 years, 2 months ago
Reviewers:
Yutaka Hirano
CC:
pywebsocket-reviews_googlegroups.com
Base URL:
http://pywebsocket.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add permessage-deflate support. Committed: 752

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 2

Patch Set 6 : Run inactivation code only for compression extensions #

Patch Set 7 : Run inactivation code only for compression extensions #

Patch Set 8 : Run inactivation code only for compression extensions #

Patch Set 9 : Removed global, added extensions import #

Patch Set 10 : Fixed processor name, inactivation code #

Patch Set 11 : Check #

Patch Set 12 : Check again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -24 lines) Patch
M src/mod_pywebsocket/extensions.py View 1 2 3 4 5 6 7 8 9 10 chunks +62 lines, -5 lines 0 comments Download
M src/mod_pywebsocket/handshake/hybi.py View 1 2 3 4 5 6 7 8 9 3 chunks +13 lines, -1 line 0 comments Download
M src/test/client_for_testing.py View 1 2 3 4 5 6 7 8 9 7 chunks +17 lines, -15 lines 0 comments Download
M src/test/test_endtoend.py View 1 2 3 4 5 6 7 8 9 2 chunks +167 lines, -0 lines 0 comments Download
M src/test/test_extensions.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7
tyoshino (chromium.org)
12 years, 2 months ago (2013-04-15 10:54:12 UTC) #1
Yutaka Hirano
https://codereview.appspot.com/8666044/diff/6001/src/mod_pywebsocket/extensions.py File src/mod_pywebsocket/extensions.py (right): https://codereview.appspot.com/8666044/diff/6001/src/mod_pywebsocket/extensions.py#newcode897 src/mod_pywebsocket/extensions.py:897: global _compression_extension_names Is this statement necessary? https://codereview.appspot.com/8666044/diff/9001/src/mod_pywebsocket/handshake/hybi.py File src/mod_pywebsocket/handshake/hybi.py ...
12 years, 2 months ago (2013-04-15 13:08:35 UTC) #2
tyoshino (chromium.org)
https://codereview.appspot.com/8666044/diff/6001/src/mod_pywebsocket/extensions.py File src/mod_pywebsocket/extensions.py (right): https://codereview.appspot.com/8666044/diff/6001/src/mod_pywebsocket/extensions.py#newcode897 src/mod_pywebsocket/extensions.py:897: global _compression_extension_names On 2013/04/15 13:08:36, Yutaka Hirano wrote: > ...
12 years, 2 months ago (2013-04-15 13:18:16 UTC) #3
Yutaka Hirano
lgtm
12 years, 2 months ago (2013-04-15 13:19:33 UTC) #4
tyoshino (chromium.org)
On 2013/04/15 13:19:33, Yutaka Hirano wrote: > lgtm Lots of bugs found... Fixed all. Now ...
12 years, 2 months ago (2013-04-15 13:47:30 UTC) #5
Yutaka Hirano
On 2013/04/15 13:47:30, tyoshino (Chromium) wrote: > On 2013/04/15 13:19:33, Yutaka Hirano wrote: > > ...
12 years, 2 months ago (2013-04-15 13:59:42 UTC) #6
tyoshino (chromium.org)
12 years, 2 months ago (2013-04-16 05:53:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #12 manually as r752 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b