Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 8654047: Don't pass extra arguments to simple event handlers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by kpreid2
Modified:
12 years, 10 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When running a simple event handler function call, don't pass more arguments than the parsed call requested, by passing plugin_dispatchEvent___ an argument count. (It was tempting to add a generalized mechanism for allowing reordered and constant arguments, but that would just be enhancing ES5/3 while we're trying to move away from it.) Incidental test suite fix: testExceptionInEventHandler does not install an onerror handler until it is about to be invoked, so that unexpected errors from other tests are not interfered with. Fixes <https://code.google.com/p/google-caja/issues/detail?id=1483>. @r5386

Patch Set 1 #

Patch Set 2 : Don't pass extra arguments to simple event handlers. #

Messages

Total messages: 5
kpreid2
12 years, 10 months ago (2013-04-24 17:24:13 UTC) #1
kpreid2
ping
12 years, 10 months ago (2013-04-29 17:26:53 UTC) #2
ihab.awad
lgtm
12 years, 10 months ago (2013-04-29 22:22:43 UTC) #3
kpreid2
When running a simple event handler function call, don't pass more arguments than the parsed ...
12 years, 10 months ago (2013-04-30 17:52:32 UTC) #4
kpreid2
12 years, 10 months ago (2013-04-30 17:54:44 UTC) #5
New snapshot for the record: I had the test arguments wrong so the 2-arg test
wasn't actually testing the SIMPLE_HANDLER_PATTERN case; this was caught since
it causes a test failure on ES5/3.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b