Issue 8649050: JS: Fix some compiler issues. Add missing ReginoCode.CH in regioncodefortesting.js. Change visibili…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8649050: JS: Fix some compiler issues. Add missing ReginoCode.CH in regioncodefortesting.js. Change visibili… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by tronikos1

Modified:
12 years, 7 months ago

Reviewers:
lararennie, shaopengjia

CC:
tronikos

Base URL:
http://libphonenumber.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

JS: Fix some compiler issues. Add missing ReginoCode.CH in regioncodefortesting.js. Change visibility of isNumberGeographical to public so that it can be accessed from tests. Committed: https://code.google.com/p/libphonenumber/source/detail?r=564

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	javascript/i18n/phonenumbers/phonenumberutil.js	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	javascript/i18n/phonenumbers/phonenumberutil_test.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	javascript/i18n/phonenumbers/regioncodefortesting.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tronikos1

12 years, 7 months ago (2013-04-23 07:36:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r564 (presubmit successful).

Expand All Messages | Collapse All Messages