Issue 8641045: call webdriver.quit() to clean up

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8641045: call webdriver.quit() to clean up (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by felix8a

Modified:
12 years, 11 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

If we don't call webdriver.quit(), the 'chromedriver' process never exits, and each chrome browser test run (successful or not) will leave four new chromedriver processes hanging around indefinitely.

Patch Set 2 : call webdriver.quit() to clean up #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	tests/com/google/caja/plugin/BrowserTestCase.java	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	tests/com/google/caja/plugin/WebDriverHandle.java	View	1	3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kpreid2

https://codereview.appspot.com/8641045/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java File tests/com/google/caja/plugin/WebDriverHandle.java (right): https://codereview.appspot.com/8641045/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java#newcode117 tests/com/google/caja/plugin/WebDriverHandle.java:117: driver.quit(); Why call driver.quit() twice?

12 years, 11 months ago (2013-04-15 16:44:32 UTC) #2

felix8a

If we don't call webdriver.quit(), the 'chromedriver' process never exits, and each chrome browser test ...

12 years, 11 months ago (2013-04-15 16:49:58 UTC) #3

felix8a

12 years, 11 months ago (2013-04-15 16:50:10 UTC) #4

LGTM

Expand All Messages | Collapse All Messages