Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 8622044: Eliminate SES guest frames and execute guest code in taming frame. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by kpreid2
Modified:
12 years, 12 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* In ES5 mode, use the taming frame instead of the guest frame for evaluating guest code. * Don't create a guest frame. * Rename ses-taming-frame.js to ses-single-frame.js. This improves performance by loading fewer frames, especially when there are multiple guests. It also makes way for being able to operate in the presence of the 'Firefox 15 cross-frame freeze bug', since the objects exposed to the guest are no longer from a different frame. This also removes the possibility of implementing "CES" (guest frames with unfrozen primordial objects); we will have to revert these changes if that becomes needed). Caveats: * guestManager.iframe is now always the combined frame, and if clients depended on it being distinct they are now wrong. We should deprecate that access and give it a more clearly for-internal-testing-only name. * mitigateGotchas is no longer excluded from the taming frame because that distinction does not exist. @r5351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -101 lines) Patch
M build.xml View 4 chunks +9 lines, -31 lines 0 comments Download
M src/com/google/caja/plugin/caja.js View 1 chunk +3 lines, -4 lines 0 comments Download
M src/com/google/caja/plugin/guest-manager.js View 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/ses-frame-group.js View 7 chunks +24 lines, -66 lines 0 comments Download

Messages

Total messages: 3
kpreid2
12 years, 12 months ago (2013-04-12 00:22:02 UTC) #1
kpreid2
Notes: - This review currently incorporates cleanup https://codereview.appspot.com/8687044/ ; please review that one first so ...
12 years, 12 months ago (2013-04-12 01:00:07 UTC) #2
ihab.awad
12 years, 12 months ago (2013-04-12 02:10:00 UTC) #3
Brilliant! LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b