Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(604)

Issue 862041: ns-3: Initial support for the 802.11g PHY (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Dean
Modified:
10 years, 10 months ago
Reviewers:
Nicola Baldo
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This patch aims to add basic support for IEEE 802.11g devices to ns-3. It corresponds to Bug 852 in the ns-3 Bugzilla module. The patch adds 802.11g WifiModes which are much like the 802.11a counterparts, but with 802.11b slot time (no short slot time support at this stage) and the 6 us signal extension after last symbol. I also copied from the basic transmit duration tests for 802.11a in the interference helper test code to provide some coverage of 802.11g burst durations. Note that the approach taken here means that devices configured as WIFI_PHY_STANDARD_80211g can quite reasonably use "802.11b" rates. This avoids further duplication of code and storage, and also suits the logic that is necessary for selection of rates for automatic control responses.

Patch Set 1 : Enable basic 802.11g support in ns-3 #

Total comments: 5

Patch Set 2 : Updated draft patchset for 802.11g support in ns-3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -8 lines) Patch
M src/devices/mesh/dot11s/peer-link-frame.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/devices/wifi/adhoc-wifi-mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/wifi/interference-helper.cc View 1 5 chunks +14 lines, -0 lines 0 comments Download
M src/devices/wifi/interference-helper-tx-duration-test.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/devices/wifi/mgt-headers.cc View 12 chunks +12 lines, -0 lines 0 comments Download
M src/devices/wifi/nist-error-rate-model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/devices/wifi/nqap-wifi-mac.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/wifi/nqsta-wifi-mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/wifi/qadhoc-wifi-mac.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/wifi/qap-wifi-mac.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/wifi/qsta-wifi-mac.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/wifi/rraa-wifi-manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/devices/wifi/supported-rates.h View 1 2 chunks +70 lines, -1 line 0 comments Download
M src/devices/wifi/supported-rates.cc View 1 3 chunks +93 lines, -4 lines 0 comments Download
M src/devices/wifi/wifi-mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/devices/wifi/wifi-mac.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/devices/wifi/wifi-phy.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/devices/wifi/wifi-phy.cc View 1 2 chunks +116 lines, -0 lines 0 comments Download
M src/devices/wifi/wifi-phy-standard.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/devices/wifi/yans-error-rate-model.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/devices/wifi/yans-wifi-phy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/devices/wifi/yans-wifi-phy.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Nicola Baldo
Most of the patch is ok, the main thing that I would like you to ...
11 years, 2 months ago (2010-04-12 17:43:08 UTC) #1
Dean
Nicola, Thank you for your comments. Some responses below... > ...the main thing I would ...
11 years, 2 months ago (2010-04-22 21:54:42 UTC) #2
Dean
I've updated the code proposed to address Bug 852 ("Add support for 802.11g devices"). The ...
10 years, 10 months ago (2010-08-25 09:27:51 UTC) #3
Dean
I've updated the code proposed to address Bug 852 ("Add support for 802.11g devices"). The ...
10 years, 10 months ago (2010-08-25 16:04:36 UTC) #4
Dean
10 years, 10 months ago (2010-08-26 11:02:36 UTC) #5
I've updated the code proposed to address Bug 852 ("Add support for 802.11g
devices").

The draft patch builds on the fixes for Bugs 871 and 881. This patch is also
available (split into it's two constituent changesets) at the head of
http://code.nsnam.org/deanarm/ns-3-dev-80211g

(Nicola; I'm sorry you're getting this multiple times on cc - there is something
funny going on between Rietveld and the ns-3-reviews group so the original one
didn't get through. I'm retrying to test a change that Mathieu has made.)

Regards,
Dean.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b