Issue 86030044: Fix and improve arm64 atomic operations in protobuf stubs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86030044: Fix and improve arm64 atomic operations in protobuf stubs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rmcilroy

Modified:
10 years, 7 months ago

Reviewers:
xiaofeng

Base URL:
http://protobuf.googlecode.com/svn/trunk/src/google/protobuf/stubs/

Visibility:
Public.

More Reviews

Description

Fix and improve arm64 atomic operations in Base. - The 'compare and swap' operations should enforce memory ordering even when the exchange does not occur. - The exclusive monitor does not need to be cleared by CLREX if a LDRX was not followed by a matching STREX. - Use LDAR and STLR where possible. - Use the 'I' and 'J' constraints to hint for constants valid for immediate values Based on V8 changes at https://codereview.chromium.org/220793002 BUG=354405

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -97 lines)			Patch
	MM	atomicops_internals_arm64_gcc.h	View		15 chunks	+56 lines, -97 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Committed as r523

Expand All Messages | Collapse All Messages