Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(495)

Issue 8589043: publish: test charm locally before publishing

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by niemeyer
Modified:
10 years, 11 months ago
Reviewers:
Danilo, dimitern, mp+157926
Visibility:
Public.

Description

publish: test charm locally before publishing https://code.launchpad.net/~niemeyer/juju-core/publish-local-tests/+merge/157926 Requires: https://code.launchpad.net/~niemeyer/juju-core/func-validators/+merge/157924 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : publish: test charm locally before publishing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/publish.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
M cmd/juju/publish_test.go View 1 9 chunks +27 lines, -12 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
10 years, 11 months ago (2013-04-09 17:52:30 UTC) #1
dimitern
LGTM
10 years, 11 months ago (2013-04-09 17:55:32 UTC) #2
Danilo
LGTM. (I was going to ask why didn't you make `meta` parameter to addMeta in ...
10 years, 11 months ago (2013-04-09 18:12:08 UTC) #3
niemeyer
Please take a look.
10 years, 11 months ago (2013-04-09 18:54:14 UTC) #4
niemeyer
10 years, 11 months ago (2013-04-09 19:10:42 UTC) #5
This was submitted as https://codereview.appspot.com/8589043/. Had to recreate
due to Launchpad/bzr wildness.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b