Issue 857048: code review 857048: Remove exp/exception as it's no longer relevant

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 857048: code review 857048: Remove exp/exception as it's no longer relevant (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by cw

Modified:
14 years, 11 months ago

Reviewers:

CC:
gri, adg, golang-dev, r, rsc

Visibility:
Public.

Description

Remove exp/exception as it's no longer relevant

Patch Set 1 : code review 857048: Remove exp/exception as it's no longer relevant #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -156 lines)			Patch
M	src/pkg/Makefile	View	1 chunk	+0 lines, -1 line	0 comments	Download
R	src/pkg/exp/exception/Makefile	View	1 chunk	+0 lines, -11 lines	0 comments	Download
R	src/pkg/exp/exception/exception.go	View	1 chunk	+0 lines, -83 lines	0 comments	Download
R	src/pkg/exp/exception/exception_test.go	View	1 chunk	+0 lines, -61 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello gri (cc: golang-dev@googlegroups.com, r, rsc), I'd like you to review this change.

14 years, 11 months ago (2010-04-11 06:33:06 UTC) #1

gri

LGTM On Sat, Apr 10, 2010 at 11:33 PM, <cw@f00f.org> wrote: > Reviewers: gri, > ...

14 years, 11 months ago (2010-04-11 23:27:57 UTC) #2

adg

14 years, 11 months ago (2010-04-13 00:51:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5d4c181263dd ***

Remove exp/exception as it's no longer relevant

R=gri, adg
CC=golang-dev, r, rsc
http://codereview.appspot.com/857048

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages

Issue 857048: code review 857048: Remove exp/exception as it&#39;s no longer relevant (Closed)

Description

Patch Set 1 : code review 857048: Remove exp/exception as it's no longer relevant #

Messages

Issue 857048: code review 857048: Remove exp/exception as it's no longer relevant (Closed)