Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1441)

Issue 8565045: A special state to track field selection is not necessary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Alok Priyadarshi
Modified:
10 years, 11 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

A special state to track field selection is not necessary. Identifier is sufficient to parse struct fieldname. Note that we do not need stacked lexer state anymore. TEST=WebGL conformance tests. Committed: https://code.google.com/p/angleproject/source/detail?r=2191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1024 lines, -1124 lines) Patch
M src/compiler/glslang.l View 3 chunks +4 lines, -13 lines 0 comments Download
M src/compiler/glslang.y View 3 chunks +1 line, -9 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 13 chunks +298 lines, -376 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 129 chunks +721 lines, -726 lines 0 comments Download

Messages

Total messages: 3
Alok Priyadarshi
10 years, 11 months ago (2013-04-26 16:09:46 UTC) #1
kbr1
LGTM
10 years, 11 months ago (2013-04-26 17:43:18 UTC) #2
Alok Priyadarshi
10 years, 11 months ago (2013-04-26 17:44:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r2191 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b