Issue 8565045: A special state to track field selection is not necessary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8565045: A special state to track field selection is not necessary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Alok Priyadarshi

Modified:
11 years, 7 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
https://angleproject.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

A special state to track field selection is not necessary. Identifier is sufficient to parse struct fieldname. Note that we do not need stacked lexer state anymore. TEST=WebGL conformance tests. Committed: https://code.google.com/p/angleproject/source/detail?r=2191

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1024 lines, -1124 lines)			Patch
M	src/compiler/glslang.l	View	3 chunks	+4 lines, -13 lines	0 comments	Download
M	src/compiler/glslang.y	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	src/compiler/glslang_lex.cpp	View	13 chunks	+298 lines, -376 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	129 chunks	+721 lines, -726 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Alok Priyadarshi

11 years, 7 months ago (2013-04-26 17:44:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r2191 (presubmit successful).

Expand All Messages | Collapse All Messages