Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1189)

Issue 85570043: Avoid accessing observable value twice during setup of CompoundObserver (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by rafaelw
Modified:
10 years, 1 month ago
Reviewers:
arv, John Messerly
Base URL:
https://github.com/Polymer/observe-js.git@master
Visibility:
Public.

Description

Avoid accessing observable value twice during setup of CompoundObserver This was affecting polymer startup. The basic problem is that Observer.open must read the underlying value, and was called during addObserver, only shortly after to have check_ call discardChanges() -- which read the underlying value again. The solution is to delay opening the Observable until the CompoundObserver is opened R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/812e8a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M src/observe.js View 4 chunks +12 lines, -7 lines 0 comments Download
M tests/test.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2
rafaelw
Committed patchset #1 manually as r812e8a4 (presubmit successful).
10 years, 1 month ago (2014-04-08 19:33:03 UTC) #1
arv
10 years, 1 month ago (2014-04-08 19:49:20 UTC) #2
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b