Issue 85520044: Backport to es53 branch: 5671,5672,5673,5675,5676,5677

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85520044: Backport to es53 branch: 5671,5672,5673,5675,5676,5677 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by kpreid2

Modified:
11 years, 11 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/branches/es53/

Visibility:
Public.

More Reviews

Description

All changes since the previous merge except for r5674 which is an es53 removal cleanup. The merge command was svn merge -c 5671,5672,5673,5675,5676,5677 ^/trunk and there was one conflict, which was just whitespace. @r5678

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+363 lines, -174 lines)			Patch
M	.	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	src/com/google/caja/lang/html/html4-attributes-defs.json	View	1 chunk	+3 lines, -14 lines	0 comments	Download
M	src/com/google/caja/lang/html/html4-attributes-whitelist.json	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/com/google/caja/lang/html/html5-attributes-defs.json	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/com/google/caja/lang/html/html5-attributes-whitelist.json	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/domado.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/html-emitter.js	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	src/com/google/caja/ses/compileExprLater.js	View	4 chunks	+28 lines, -43 lines	0 comments	Download
M	src/com/google/caja/ses/debug.js	View	3 chunks	+121 lines, -30 lines	0 comments	Download
M	src/com/google/caja/ses/explicit.html	View	4 chunks	+61 lines, -30 lines	0 comments	Download
M	src/com/google/caja/ses/makeSimpleAMDLoader.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/com/google/caja/ses/repair-framework.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/ses/startSES.js	View	9 chunks	+68 lines, -17 lines	0 comments	Download
M	src/com/google/caja/ses/useHTMLLogger.js	View	2 chunks	+53 lines, -16 lines	0 comments	Download
MM	tests/com/google/caja/plugin/test-domado-dom-guest.html	View	3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jasvir

11 years, 11 months ago (2014-04-08 17:37:53 UTC) #2

On 2014/04/08 17:29:41, kpreid2 wrote:

LGTM

Remove the first line in the patch for "."

Expand All Messages | Collapse All Messages