Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(545)

Issue 855046: code review 855046: runtime: delete malx, skip_depth argument to malloc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by rsc
Modified:
14 years, 11 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

runtime: delete malx, skip_depth argument to malloc remove internal functions from traces in gopprof instead.

Patch Set 1 #

Patch Set 2 : code review 855046: runtime: delete malx, skip_depth argument to malloc #

Patch Set 3 : code review 855046: runtime: delete malx, skip_depth argument to malloc #

Patch Set 4 : code review 855046: runtime: delete malx, skip_depth argument to malloc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -28 lines) Patch
M src/cmd/prof/gopprof View 1 chunk +28 lines, -0 lines 0 comments Download
M src/pkg/runtime/iface.c View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/malloc.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/malloc.cgo View 5 chunks +5 lines, -11 lines 0 comments Download
M src/pkg/runtime/mfinal.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/mprof.cgo View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/slice.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/string.cgo View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-04-09 22:13:01 UTC) #1
r
LGTM
14 years, 11 months ago (2010-04-09 22:28:12 UTC) #2
r
oh yeah - the pprof stuff looks unrelated.
14 years, 11 months ago (2010-04-09 22:28:30 UTC) #3
rsc
the pprof stuff is taking the place of all the skip_delta logic in runtime. both ...
14 years, 11 months ago (2010-04-09 22:29:27 UTC) #4
rsc
14 years, 11 months ago (2010-04-09 22:30:45 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=ec6af2f05219 ***

runtime: delete malx, skip_depth argument to malloc

remove internal functions from traces in gopprof instead.

R=r
CC=golang-dev
http://codereview.appspot.com/855046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b