Issue 854046: code review 854046: test: minor updates to avoid bitrot

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 854046: code review 854046: test: minor updates to avoid bitrot (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by cw

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Patch Set 2 : code review 854046: test: minor updates to avoid bitrot #

Total comments: 1

Patch Set 3 : code review 854046: test: minor updates to avoid bitrot #

Patch Set 4 : code review 854046: test: minor updates to avoid bitrot #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	test/garbage/parser.go	View		3 chunks	+5 lines, -5 lines	0 comments	Download
	M	test/garbage/peano.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-11 06:12:53 UTC) #1

http://codereview.appspot.com/854046/diff/2001/3002 File test/garbage/peano.go (right): http://codereview.appspot.com/854046/diff/2001/3002#newcode91 test/garbage/peano.go:91: pmsg := fmt.Sprintf("error: found %d; expected %d\n", c, expected) ...

14 years, 11 months ago (2010-04-11 17:26:24 UTC) #3

Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-04-12 03:56:20 UTC) #4

rsc

14 years, 11 months ago (2010-04-13 01:10:32 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=62a3500a6424 ***

test: minor updates to avoid bitrot

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/854046

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages