Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(874)

Issue 8531043: Fix ES5/3 not freezing numeric properties sometimes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by kpreid2
Modified:
11 years, 12 months ago
Reviewers:
Jasvir
CC:
caja-discuss-undisclosed_googlegroups.com, MarkM, felix8a, ihab.awad, Jasvir, kpreid2, metaweta, MikeSamuel
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Freezing an object without a NUM___ property descriptor would generate an incomplete property descriptor resulting in a later isWritable test converting it into a writable and configurable one. This meant that any supposedly-frozen object with numeric properties and without a NUM___ had writable numeric properties; examples of such objects are the deodorized prototypes (e.g. Function.prototype) and Object.freeze(['foo']). Fixes <https://code.google.com/p/google-caja/issues/detail?id=1683>. @r5394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/com/google/caja/es53.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years ago (2013-04-08 20:52:58 UTC) #1
Jasvir
12 years ago (2013-04-08 22:11:01 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b