Issue 85150044: Fix missing bson: struct tag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85150044: Fix missing bson: struct tag

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by dave

Modified:
10 years, 1 month ago

Reviewers:
mp+214658, wallyworld, jameinel

Visibility:
Public.

Description

Fix missing bson: struct tag Spotted by go tool vet, I hope this wasn't important. https://code.launchpad.net/~dave-cheney/juju-core/fix-missing-tag-namespace/+merge/214658 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/constraints.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years, 1 month ago (2014-04-08 05:20:37 UTC) #4

I'm doing a followup branch to enable this check. We already run go
tool vet as part of the lbox cycle, but most of the checks are
disabled.

On Tue, Apr 8, 2014 at 3:19 PM,  <john.meinel@canonical.com> wrote:
> looking at the other files, they all use bson: so LGTM
>
>
> https://codereview.appspot.com/85150044/

Expand All Messages | Collapse All Messages