Issue 85040043: Whitelist modern tabindex=.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85040043: Whitelist modern tabindex=. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by kpreid_google

Modified:
11 years, 11 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

* tabindex is allowed on any element. * tabindex="-1" is allowed. For <https://code.google.com/p/google-caja/issues/detail?id=1155>. @r5677

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -20 lines)			Patch
	M	src/com/google/caja/lang/html/html4-attributes-defs.json	View		1 chunk	+3 lines, -14 lines	1 comment	Download
	M	src/com/google/caja/lang/html/html4-attributes-whitelist.json	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

felix8a

lgtm. you might want to add a testcase in tests/.../plugin/css-stylesheet-tests.js https://codereview.appspot.com/85040043/diff/1/src/com/google/caja/lang/html/html4-attributes-defs.json File src/com/google/caja/lang/html/html4-attributes-defs.json (right): https://codereview.appspot.com/85040043/diff/1/src/com/google/caja/lang/html/html4-attributes-defs.json#newcode563 ...

11 years, 11 months ago (2014-04-07 18:31:06 UTC) #2

kpreid_google

On 2014/04/07 18:31:06, felix8a wrote: > lgtm. > > you might want to add a ...

11 years, 11 months ago (2014-04-07 19:20:40 UTC) #3

felix8a

11 years, 11 months ago (2014-04-07 19:46:08 UTC) #4

Message was sent while issue was closed.

On 2014/04/07 19:20:40, kpreid_google wrote:
> On 2014/04/07 18:31:06, felix8a wrote:
> > lgtm.
> > 
> > you might want to add a testcase in tests/.../plugin/css-stylesheet-tests.js
> 
> I don't think we need tests for things that are purely set by the schema files
> and don't interact with any other features.

I've done it before for a few css/html whitelist items because
- the processing of the schema is nontrivial, so I don't have high confidence
that I understand how my source text will become behavior
- it's pattern matching, not just a list of strings, and I don't have high
confidence I can write typo-free patterns
Code review is a reasonable antidote to those problems, but there's only a
handful of people who understand this code, so tests might be a helpful
redundancy.

Expand All Messages | Collapse All Messages