Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 849046: Missing currency RAI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by yangoon1
Modified:
11 years, 1 month ago
Reviewers:
ced, udono
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Adding nummeric code #

Patch Set 3 : Changing numeric code to match english date format #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M currency.xml View 1 2 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 5
ced
http://codereview.appspot.com/849046/diff/1/2 File currency.xml (right): http://codereview.appspot.com/849046/diff/1/2#newcode1059 currency.xml:1059: <record model="currency.currency" id="rai"> currency are generated by script/currencies.py http://codereview.appspot.com/849046/diff/1/2#newcode1062 ...
11 years, 1 month ago (2010-04-01 17:34:40 UTC) #1
udono
http://codereview.appspot.com/849046/diff/1/2 File currency.xml (right): http://codereview.appspot.com/849046/diff/1/2#newcode1062 currency.xml:1062: <field name="numeric_code"></field> AFAIK the missing numeric code is 0104
11 years, 1 month ago (2010-04-01 17:39:35 UTC) #2
ced
http://codereview.appspot.com/849046/diff/1/2 File currency.xml (right): http://codereview.appspot.com/849046/diff/1/2#newcode1062 currency.xml:1062: <field name="numeric_code"></field> On 2010/04/01 17:39:37, udono wrote: > AFAIK ...
11 years, 1 month ago (2010-04-01 17:42:46 UTC) #3
yangoon1
http://codereview.appspot.com/849046/diff/1/2 File currency.xml (right): http://codereview.appspot.com/849046/diff/1/2#newcode1059 currency.xml:1059: <record model="currency.currency" id="rai"> On 2010/04/01 17:34:40, ced wrote: > ...
11 years, 1 month ago (2010-04-01 17:45:45 UTC) #4
udono
11 years, 1 month ago (2010-04-01 17:51:32 UTC) #5
http://codereview.appspot.com/849046/diff/10001/11001
File currency.xml (right):

http://codereview.appspot.com/849046/diff/10001/11001#newcode1062
currency.xml:1062: <field name="numeric_code">0401</field>
ah, yes it is right 0401 because it is depending on date format mmddyy. Sorry
for wrong trail
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b