provider/maas: Get machine NICs in StartInstance

provider/maas: Get machine NICs in StartInstance

If networks were specified, in StartInstance the
MAAS provider now requests the node details from
the server, which contain XML data from lshw that
was gathered at commissioning time. The XML is
parsed to extract a map of interface name to
MAC address. This is needed so that in a follow-up
we'll combine the information from there and from
a GetNetworksList call to return []NetworkInfo
from StartInstance.

Live tested on MAAS and whitebox tested the XML
parsing helper only, because gomaasapi's test
server does not support getting node details yet.

https://code.launchpad.net/~dimitern/juju-core/390-maas-get-node-nics/+merge/214528

(do not edit description out of merge proposal)

[dimitern, 2014-04-07 13:11:55]

Please take a look.

[vladislav.klyachin, 2014-04-07 14:45:37]

I would prefer to have a reversed map to get interface name by mac address.

[vladislav.klyachin, 2014-04-07 14:47:13]

I would prefer to have a reversed map to get interface name by mac address.

https://codereview.appspot.com/84850045/diff/1/provider/maas/environ.go
File provider/maas/environ.go (right):

https://codereview.appspot.com/84850045/diff/1/provider/maas/environ.go#newco...
provider/maas/environ.go:385: interfaces[node.LogicalName] = node.Serial
we need a reversed map here, because MAAS API provide us with MAC addresses and
this map should give an interface name by MAC address

[vladislav.klyachin, 2014-04-07 16:37:24]

LGTM

[dimitern, 2014-04-07 16:41:56]

Please take a look.

https://codereview.appspot.com/84850045/diff/1/provider/maas/environ.go
File provider/maas/environ.go (right):

https://codereview.appspot.com/84850045/diff/1/provider/maas/environ.go#newco...
provider/maas/environ.go:385: interfaces[node.LogicalName] = node.Serial
On 2014/04/07 14:47:13, vladislav.klyachin wrote:
> we need a reversed map here, because MAAS API provide us with MAC addresses
and
> this map should give an interface name by MAC address

Done.