Issue 84840043: more perf work on shared observations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84840043: more perf work on shared observations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
11 years ago

Reviewers:
arv, John Messerly

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

more perf work on shared observations R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/fca8a33

Patch Set 2 : pre commit #

Total comments: 4

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -86 lines)			Patch
	M	src/observe.js	View	1	7 chunks	+41 lines, -86 lines	4 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #2 manually as rfca8a33 (presubmit successful).

11 years ago (2014-04-05 21:12:03 UTC) #1

arv

LGTM https://codereview.appspot.com/84840043/diff/20001/src/observe.js File src/observe.js (right): https://codereview.appspot.com/84840043/diff/20001/src/observe.js#newcode419 src/observe.js:419: * is kept open, but some Observers have ...

11 years ago (2014-04-07 21:43:20 UTC) #3

rafaelw

11 years ago (2014-04-08 18:15:50 UTC) #4

Message was sent while issue was closed.

https://github.com/Polymer/observe-js/commit/c007279de53956b250825f571aa36070...

https://codereview.appspot.com/84840043/diff/20001/src/observe.js
File src/observe.js (right):

https://codereview.appspot.com/84840043/diff/20001/src/observe.js#newcode419
src/observe.js:419: * is kept open, but some Observers have been closed, it
could case "leaks"
On 2014/04/07 21:43:20, arv wrote:
> s/case/cause/

Done.

https://codereview.appspot.com/84840043/diff/20001/src/observe.js#newcode420
src/observe.js:420: * (reprevent otherwise collectable objects from being
collected). At some
On 2014/04/07 21:43:20, arv wrote:
> reprevent?

Done.

Expand All Messages | Collapse All Messages