Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(225)

Issue 848042: code review 848042: godoc: support for title and subtitle headers when serv... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by gri
Modified:
12 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev, r
Visibility:
Public.

Description

godoc: support for title and subtitle headers when serving .html docs and use it to show version (date) of go spec Fixes issue 68.

Patch Set 1 #

Patch Set 2 : code review 848042: godoc: support for title and subtitle headers when serv... #

Patch Set 3 : code review 848042: godoc: support for title and subtitle headers when serv... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -19 lines) Patch
M doc/go_spec.html View 1 chunk +2 lines, -1 line 0 comments Download
M doc/style.css View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/godoc/godoc.html View 1 chunk +8 lines, -1 line 0 comments Download
M src/cmd/godoc/godoc.go View 10 chunks +26 lines, -16 lines 0 comments Download
M src/cmd/godoc/main.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
gri
Hello rsc (cc: golang-dev@googlegroups.com, r), I'd like you to review this change.
12 years, 10 months ago (2010-03-30 23:48:41 UTC) #1
rsc1
I thought the plan was to use runtime.Version() to avoid needing to edit the date.
12 years, 10 months ago (2010-03-31 00:29:05 UTC) #2
gri
runtime.Version is already shown, but it changes much more often than the spec. It seems ...
12 years, 10 months ago (2010-03-31 00:33:12 UTC) #3
rsc
LGTM
12 years, 10 months ago (2010-03-31 00:34:54 UTC) #4
gri
12 years, 10 months ago (2010-03-31 00:37:44 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=0bf8bf7d8266 ***

godoc: support for title and subtitle headers when serving .html docs
and use it to show version (date) of go spec

Fixes issue 68.

R=rsc
CC=golang-dev, r
http://codereview.appspot.com/848042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b