Issue 848041: code review 848041: syscall: add IPV6 constants

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 848041: code review 848041: syscall: add IPV6 constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : code review 848041: syscall: add IPV6 constants #

Total comments: 1

Patch Set 3 : code review 848041: syscall: add IPV6 constants #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1255 lines, -1108 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/syscall/mksysnum_linux.sh	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_386.go	View	1 chunk	+570 lines, -519 lines	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_amd64.go	View	1 chunk	+570 lines, -519 lines	0 comments	Download
M	src/pkg/syscall/zerrors_linux_386.go	View	13 chunks	+56 lines, -33 lines	0 comments	Download
M	src/pkg/syscall/zerrors_linux_amd64.go	View	13 chunks	+56 lines, -33 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-30 21:16:33 UTC) #1

LGTM http://codereview.appspot.com/848041/diff/2001/3004 File src/pkg/syscall/zerrors_darwin_amd64.go (right): http://codereview.appspot.com/848041/diff/2001/3004#newcode12 src/pkg/syscall/zerrors_darwin_amd64.go:12: AF_APPLETALK = 0x10 they've gotta be kidding.

15 years ago (2010-03-30 21:28:19 UTC) #2

rsc

15 years ago (2010-03-30 21:33:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=842b5b538f42 ***

syscall: add IPV6 constants

R=r
CC=golang-dev
http://codereview.appspot.com/848041

Expand All Messages | Collapse All Messages