Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 84730043: Tuplet brackets should reliably not follow kneed beams.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Devon Schudy
Modified:
5 years, 5 months ago
Reviewers:
dak, david.nalesnik
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Tuplet brackets should reliably not follow kneed beams. Previously they could follow a beam if Beam::is_knee had not been called on it yet. This affects input/regression/tuplet-number-kneed-beam-horizontal-fit.ly, and the following: { \override TupletBracket.bracket-visibility = ##t \times 1/2 { c8 c''' c c''' } } Is it safe to call Beam::is_knee in Tuplet_bracket::calc_position_and_height?

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix inaccurate description of test result. #

Patch Set 3 : Fix inaccurate test description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M input/regression/tuplet-number-kneed-beam-horizontal-fit.ly View 1 1 chunk +4 lines, -1 line 0 comments Download
M lily/tuplet-bracket.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
david.nalesnik
https://codereview.appspot.com/84730043/diff/1/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly File input/regression/tuplet-number-kneed-beam-horizontal-fit.ly (right): https://codereview.appspot.com/84730043/diff/1/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly#newcode10 input/regression/tuplet-number-kneed-beam-horizontal-fit.ly:10: Don't you mean only the second tuplet number should ...
5 years, 5 months ago (2014-04-05 13:25:05 UTC) #1
Devon Schudy
David Nalesnik wrote: > https://codereview.appspot.com/84730043/diff/1/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly#newcode10 > input/regression/tuplet-number-kneed-beam-horizontal-fit.ly:10: > Don't you mean only the second tuplet ...
5 years, 5 months ago (2014-04-07 03:06:07 UTC) #2
Devon Schudy
Fix inaccurate description of test result.
5 years, 5 months ago (2014-04-07 03:18:41 UTC) #3
Devon Schudy
Fix inaccurate test description.
5 years, 5 months ago (2014-04-07 04:16:52 UTC) #4
dak
Devon Schudy <dschudy@gmail.com> writes: > David Nalesnik wrote: >> https://codereview.appspot.com/84730043/diff/1/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly#newcode10 >> input/regression/tuplet-number-kneed-beam-horizontal-fit.ly:10: >> Don't you ...
5 years, 5 months ago (2014-04-07 07:33:22 UTC) #5
david.nalesnik
On Mon, Apr 7, 2014 at 2:32 AM, David Kastrup <dak@gnu.org> wrote: > > > ...
5 years, 5 months ago (2014-04-07 12:49:59 UTC) #6
david.nalesnik
5 years, 5 months ago (2014-04-07 12:58:37 UTC) #7
On 2014/04/07 04:16:52, Devon Schudy wrote:
> Fix inaccurate test description.

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b