Tames and exposes google analytics

* whitelists GA and its methods for use in cajoled gadgets

@943203

[chirag, 2010-03-31 20:11:42]

Need to add <script src="taming.js"/> to analytics/feature.xml

[Jasvir, 2010-03-31 20:17:50]

Done.

[chirag, 2010-03-31 21:20:21]

http://codereview.appspot.com/847044/diff/4001/5002
File features/src/main/javascript/features/analytics/taming.js (right):

http://codereview.appspot.com/847044/diff/4001/5002#newcode30
features/src/main/javascript/features/analytics/taming.js:30: [window._IG_GA,
'reportPageview'],
I cannot find where this method is implemented. I'm also not able to review
libanalytics.js and urchin.js since they're both obfuscated.

[Jasvir, 2010-05-10 22:06:21]

* moved taming to the directory where analytics functions are hooked up to
gadgets.analytics

* unfortunately there isn't an unobfuscated version of libga available for
review

[johnfargo, 2010-05-10 22:19:36]

lgtm, will patch.

On 2010/05/10 22:06:21, jasvir wrote:
> * moved taming to the directory where analytics functions are hooked up to
> gadgets.analytics
> 
> * unfortunately there isn't an unobfuscated version of libga available for
> review

[johnfargo, 2010-05-10 23:31:16]

Uh, just patched this, but completely forgot that you have committer access now.
:P

On 2010/05/10 22:19:36, johnfargo wrote:
> lgtm, will patch.
> 
> On 2010/05/10 22:06:21, jasvir wrote:
> > * moved taming to the directory where analytics functions are hooked up to
> > gadgets.analytics
> > 
> > * unfortunately there isn't an unobfuscated version of libga available for
> > review

[jas_nagras.com, 2010-05-10 23:35:31]

heh.  I am fine with that as long as it gets applied! :)

-- 
Jasvir Nagra
http://www.cs.auckland.ac.nz/~jas


On Mon, May 10, 2010 at 4:31 PM, <johnfargo@gmail.com> wrote:

> Uh, just patched this, but completely forgot that you have committer
> access now. :P
>
>
> On 2010/05/10 22:19:36, johnfargo wrote:
>
>> lgtm, will patch.
>>
>
>  On 2010/05/10 22:06:21, jasvir wrote:
>> > * moved taming to the directory where analytics functions are hooked
>>
> up to
>
>> > gadgets.analytics
>> >
>> > * unfortunately there isn't an unobfuscated version of libga
>>
> available for
>
>> > review
>>
>
>
>
> http://codereview.appspot.com/847044/show
>