Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Issue 846046: Update Caja to r4052 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by johnfargo
Modified:
15 years, 8 months ago
Reviewers:
shindig.remailer, Jasvir
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Early patch; not yet complete. In addition to the API update, changes CajaContentRewriter to fetch using HttpFetcher.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -118 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/ParseModule.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java View 1 chunk +39 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AuthenticationModule.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java View 2 chunks +101 lines, -102 lines 1 comment Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/RpcServlet.java View 2 chunks +0 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java View 1 chunk +1 line, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java View 1 chunk +1 line, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/AbstractParsingTestBase.java View 2 chunks +4 lines, -3 lines 1 comment Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaParserAndSerializerTest.java View 1 chunk +8 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/HttpPreloaderTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloaderTest.java View 2 chunks +0 lines, -3 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
java/gadgets/src/test/resources/org/apache/shindig/gadgets/parse/test-vml.html View 1 chunk +32 lines, -0 lines 0 comments Download
pom.xml View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 6
johnfargo
15 years, 9 months ago (2010-04-08 06:44:55 UTC) #1
Jasvir
http://codereview.appspot.com/846046/diff/1/8 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/846046/diff/1/8#newcode180 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:180: } else if ("javascript".equalsIgnoreCase(uri.getScheme())) { This rev of Caja ...
15 years, 9 months ago (2010-04-25 20:40:26 UTC) #2
Jasvir
ping?
15 years, 8 months ago (2010-05-04 17:46:12 UTC) #3
johnfargo
On 2010/04/25 20:40:26, jasvir wrote: > http://codereview.appspot.com/846046/diff/1/8 > File > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java > (right): > > ...
15 years, 8 months ago (2010-05-04 18:41:51 UTC) #4
Jasvir
http://codereview.appspot.com/846046/diff/1/15 File pom.xml (right): http://codereview.appspot.com/846046/diff/1/15#newcode1381 pom.xml:1381: <version>r3950</version> You'll also need htmlparser which has now been ...
15 years, 8 months ago (2010-05-04 19:59:19 UTC) #5
fargo
15 years, 8 months ago (2010-05-04 20:00:41 UTC) #6
Adding and trying out the tests once more..

On Tue, May 4, 2010 at 12:59 PM, <jasvir@gmail.com> wrote:

>
> http://codereview.appspot.com/846046/diff/1/15
> File pom.xml (right):
>
> http://codereview.appspot.com/846046/diff/1/15#newcode1381
> pom.xml:1381: <version>r3950</version>
> You'll also need htmlparser which has now been split out into a separate
> maven dependency:
>      <dependency>
>        <groupId>caja</groupId>
>        <artifactId>htmlparser</artifactId>
>        <version>r4052</version>
>        <scope>compile</scope>
>      </dependency>
>
>
>
> On 2010/04/25 20:40:26, jasvir wrote:
>
>> Update rev?
>>
>
> http://codereview.appspot.com/846046/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b