destroy-env should remove security groups

destroy-env should remove security groups

fix for bug 1227574.

The implementation is obvious, I think. As described in bug 1300755
it can happen that a security group cannot be deleted because it is
used in another environment. The Nova API call fails in this case,
so trying this call does not affect the other environment.

Unfortunately, goose hides the original error message, so Destroy()
ans StopInstance() cannot determine the exact reason of the failure.
Hence only a warning is logged.

https://code.launchpad.net/~adeuring/juju-core/1227574/+merge/214520

(do not edit description out of merge proposal)

[abel.deuring, 2014-04-07 12:20:36]

Please take a look.

[mue, 2014-04-07 14:25:48]

Only minor notes, otherwise LGTM.

https://codereview.appspot.com/84470053/diff/1/provider/openstack/local_test.go
File provider/openstack/local_test.go (right):

https://codereview.appspot.com/84470053/diff/1/provider/openstack/local_test....
provider/openstack/local_test.go:452: func (s *localServerSuite)
TestDestroyEnvironmentDeletesSecurityGroupsFWModeGlobabel(c *gc.C) {
Hehe, only naming: ...FWModeGlobal. ;)

https://codereview.appspot.com/84470053/diff/1/provider/openstack/provider.go
File provider/openstack/provider.go (right):

https://codereview.appspot.com/84470053/diff/1/provider/openstack/provider.go...
provider/openstack/provider.go:879: lastDash := strings.LastIndex(openstackName,
"-")
Would call it "lastDashPos".

https://codereview.appspot.com/84470053/diff/1/provider/openstack/provider.go...
provider/openstack/provider.go:881: return fmt.Errorf("Cannot identify instance
ID in openstack server name %q", openstackName)
IMHO errors start lower-case.

https://codereview.appspot.com/84470053/diff/1/provider/openstack/provider.go...
provider/openstack/provider.go:1001: logger.Warningf("Cannot delete security
group %q. Used by another environment?", group.Name)
Same here, lower-case.