code review 844044: godashboard: fix benchmarks page (first pass)

godashboard: fix benchmarks page (first pass)

[adg, 2010-04-04 12:03:37]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2010-04-04 12:08:26]

See it here:
http://adg.latest.godashboard.appspot.com/benchmarks

I used a bit of a nasty trick to work around App Engine's time limits.
The data for each sparkline is built with a separate HTTP request,
unless it has been generated recently and is cached. It actually works
surprisingly well.

I didn't clean out any of the cruft (conversion, old storage models,
etc), as I just wanted this working for now.

I can definitely make this much better by sensibly partitioning the
results and just generally cleaning it up. It'll take a bit of time to
make it nice, though.

Andrew

On 4 April 2010 23:03,  <adg@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> godashboard: fix benchmarks page (first pass)
>
> Please review this at http://codereview.appspot.com/844044/show
>
> Affected files:
>  M misc/dashboard/godashboard/benchmark1.html
>  M misc/dashboard/godashboard/benchmarks.html
>  M misc/dashboard/godashboard/gobuild.py
>
>
>

[rsc1, 2010-04-04 17:41:49]

LGTM

http://codereview.appspot.com/844044/diff/7001/8001
File misc/dashboard/godashboard/benchmark1.html (right):

http://codereview.appspot.com/844044/diff/7001/8001#newcode6
misc/dashboard/godashboard/benchmark1.html:6: <!--
delete commented out style

http://codereview.appspot.com/844044/diff/7001/8002
File misc/dashboard/godashboard/benchmarks.html (right):

http://codereview.appspot.com/844044/diff/7001/8002#newcode6
misc/dashboard/godashboard/benchmarks.html:6: <!--
delete commented out style

http://codereview.appspot.com/844044/diff/7001/8003
File misc/dashboard/godashboard/gobuild.py (right):

http://codereview.appspot.com/844044/diff/7001/8003#newcode465
misc/dashboard/godashboard/gobuild.py:465: and return sparkline url as HTTP
redirect, also set memcache entry.
haha.  fantastic.

[adg, 2010-04-04 21:34:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=032e8ca8bb13 ***

godashboard: fix benchmarks page (first pass)

R=rsc
CC=golang-dev
http://codereview.appspot.com/844044