Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 8410044: Update adexchangebuyer samples to use apiclient.sample_tools. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by jcgregorio_google
Modified:
12 years, 3 months ago
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

Update adexchangebuyer samples to use apiclient.sample_tools.

Patch Set 1 #

Total comments: 4

Patch Set 2 : missing ints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -194 lines) Patch
M samples/adexchangebuyer/get_all_accounts.py View 1 chunk +9 lines, -9 lines 0 comments Download
M samples/adexchangebuyer/get_creative.py View 2 chunks +18 lines, -20 lines 0 comments Download
M samples/adexchangebuyer/get_direct_deals.py View 2 chunks +8 lines, -8 lines 0 comments Download
R samples/adexchangebuyer/sample_utils.py View 1 chunk +0 lines, -112 lines 0 comments Download
M samples/adexchangebuyer/submit_creative.py View 1 2 chunks +22 lines, -25 lines 0 comments Download
M samples/adexchangebuyer/update_account.py View 1 2 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 6
jcgregorio_google
12 years, 3 months ago (2013-04-05 17:57:21 UTC) #1
Joseph DiLallo
Thanks for updating these. I have just 1 minor questions about the argparse declarations... https://codereview.appspot.com/8410044/diff/1/samples/adexchangebuyer/submit_creative.py ...
12 years, 3 months ago (2013-04-05 18:13:36 UTC) #2
jcgregorio_google
https://codereview.appspot.com/8410044/diff/1/samples/adexchangebuyer/submit_creative.py File samples/adexchangebuyer/submit_creative.py (right): https://codereview.appspot.com/8410044/diff/1/samples/adexchangebuyer/submit_creative.py#newcode39 samples/adexchangebuyer/submit_creative.py:39: argparser.add_argument('agency_id', On 2013/04/05 18:13:36, Joseph DiLallo wrote: > We ...
12 years, 3 months ago (2013-04-05 18:18:15 UTC) #3
Joseph DiLallo
LGTM
12 years, 3 months ago (2013-04-05 18:19:03 UTC) #4
jcgregorio_google
Commited in https://code.google.com/p/google-api-python-client/source/detail?r=34b8b6279505d3100bf135441d901c8c5168944f On Fri, Apr 5, 2013 at 2:19 PM, <jdilallo@google.com> wrote: > LGTM ...
12 years, 3 months ago (2013-04-05 18:26:50 UTC) #5
jcgregorio_google
12 years, 3 months ago (2013-04-05 18:26:56 UTC) #6
Message was sent while issue was closed.
On 2013/04/05 18:19:03, Joseph DiLallo wrote:
> LGTM

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=34b8b62795...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b