Add a 'maintainer's field.

Add a 'maintainer's field.

It was decided on the mailing list that the 'maintainer' field should be
renamed to 'maintainers' to make it clear that there can be more than one.
Note the old 'maintainer' field was capable of being a single entity or a list
just fine.

So for backward compatability, 'maintainer' is preserved, 'maintainers' is
added and the actual value used is the union of the two, with duplicates
removed.  

On the charm page the heading has been changed to 'Maintainer(s)" and an
unordered list is used to present the names.

https://code.launchpad.net/~bac/charmworld/add-maintainers/+merge/213858

(do not edit description out of merge proposal)

[bac, 2014-04-02 14:32:32]

Please take a look.

[rharding, 2014-04-02 16:38:02]

LGTM with a couple of comments. Thanks for the update.

https://codereview.appspot.com/83620043/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/83620043/diff/1/charmworld/models.py#newcode680
charmworld/models.py:680: # The 'maintainer' field is deprecated but not yet
phased out.
should this be an XXX with a bug to remove at some point?

https://codereview.appspot.com/83620043/diff/1/charmworld/testing/factory.py
File charmworld/testing/factory.py (right):

https://codereview.appspot.com/83620043/diff/1/charmworld/testing/factory.py#...
charmworld/testing/factory.py:184: store_revision=1, maintainers=None):
do we call this with ordered args? I'd suggest placing it by the maintainer key
so that it's easier to see both exist.

https://codereview.appspot.com/83620043/diff/1/charmworld/testing/factory.py#...
charmworld/testing/factory.py:203: if maintainers is None:
because we merge maintainer into maintainers, should maintainers get the same
treatment here?

https://codereview.appspot.com/83620043/diff/1/charmworld/tests/test_models.py
File charmworld/tests/test_models.py (right):

https://codereview.appspot.com/83620043/diff/1/charmworld/tests/test_models.p...
charmworld/tests/test_models.py:490: def test_maintainer_single(self):
should these be 'test_maintainers_single' for example?

https://codereview.appspot.com/83620043/diff/1/charmworld/tests/test_models.p...
charmworld/tests/test_models.py:497: self.assertEqual([maintainer],
charm.maintainers)
or should this assert against charm.maintainer (sans s)?

[bac, 2014-04-02 18:15:26]

Thanks for the review

https://codereview.appspot.com/83620043/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/83620043/diff/1/charmworld/models.py#newcode680
charmworld/models.py:680: # The 'maintainer' field is deprecated but not yet
phased out.
We aren't the drivers for it getting removed and I suspect the replacement will
be up before then.

https://codereview.appspot.com/83620043/diff/1/charmworld/testing/factory.py
File charmworld/testing/factory.py (right):

https://codereview.appspot.com/83620043/diff/1/charmworld/testing/factory.py#...
charmworld/testing/factory.py:184: store_revision=1, maintainers=None):
Good point.  I'm in the habit of adding new params to the end of the list but
since they are all kwargs it shouldn't matter.

https://codereview.appspot.com/83620043/diff/1/charmworld/testing/factory.py#...
charmworld/testing/factory.py:203: if maintainers is None:
Perhaps.  Let me see if there is fallout.

https://codereview.appspot.com/83620043/diff/1/charmworld/tests/test_models.py
File charmworld/tests/test_models.py (right):

https://codereview.appspot.com/83620043/diff/1/charmworld/tests/test_models.p...
charmworld/tests/test_models.py:490: def test_maintainer_single(self):
The test name refers to the input.  Kind of confusing but I needed a way to
distinguish between the next set.

https://codereview.appspot.com/83620043/diff/1/charmworld/tests/test_models.p...
charmworld/tests/test_models.py:497: self.assertEqual([maintainer],
charm.maintainers)
No, charm.maintainer, the derived property, no long exists.  It is the plural
version now.

maintainer and maintainers are the inputs from metadata.yaml and are kept in the
_representation dict but the property only exists as charm.maintainers.