Issue 8346043: Security fixes to woff2 decompression

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8346043: Security fixes to woff2 decompression

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by raph

Modified:
12 years, 3 months ago

Reviewers:
ksakamoto, agl

Visibility:
Public.

More Reviews

Description

Security fixes to woff2 decompression

Patch Set 1 #

Patch Set 2 : Cleaned up changed files #

Total comments: 1

Patch Set 3 : Fix line I forgot to delete #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -25 lines)			Patch
	M	cpp/woff2.cc	View	1 2	11 chunks	+21 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ksakamoto

Thanks Raph for the patch! I'll defer to Adam for expertise, but just a nit: ...

12 years, 3 months ago (2013-04-04 08:59:36 UTC) #1

raph

12 years, 3 months ago (2013-04-06 00:04:49 UTC) #3

Very good catch, thanks. I'm committing based on the two lgtm's.
Please let me know if there are any other issues.

On Thu, Apr 4, 2013 at 6:56 AM,  <agl@chromium.org> wrote:
> LGTM with ksakamoto's nits.
>
> https://codereview.appspot.com/8346043/

Expand All Messages | Collapse All Messages