Give upload.py a module-scope logger

Give upload.py a module-scope logger

[agable1, 2014-04-02 01:35:19]

Prerequisite for https://codereview.chromium.org/221423007

[M-A, 2014-04-02 17:20:54]

lgtm with fix.

https://codereview.appspot.com/83380043/diff/1/upload.py
File upload.py (right):

https://codereview.appspot.com/83380043/diff/1/upload.py#newcode2704
upload.py:2704: "%(lineno)s %(message)s "))
I think you have to put level=logging.DEBUG here to not break standalone usage.

[agable1, 2014-04-04 01:30:03]

https://codereview.appspot.com/83380043/diff/1/upload.py
File upload.py (right):

https://codereview.appspot.com/83380043/diff/1/upload.py#newcode2704
upload.py:2704: "%(lineno)s %(message)s "))
On 2014/04/02 17:20:55, M-A wrote:
> I think you have to put level=logging.DEBUG here to not break standalone
usage.

The default root logger logs with loglevel WARNING. And one or more -v flags
passed to this script standalone will still trigger the logic on line 2536.

[M-A, 2014-04-04 13:43:00]

https://codereview.appspot.com/83380043/diff/1/upload.py
File upload.py (right):

https://codereview.appspot.com/83380043/diff/1/upload.py#newcode2704
upload.py:2704: "%(lineno)s %(message)s "))
On 2014/04/04 01:30:03, agable1 wrote:
> On 2014/04/02 17:20:55, M-A wrote:
> > I think you have to put level=logging.DEBUG here to not break standalone
> usage.
> 
> The default root logger logs with loglevel WARNING. And one or more -v flags
> passed to this script standalone will still trigger the logic on line 2536.

Confirmed? If so, lgtm.

[agable1, 2014-04-04 18:56:54]

On 2014/04/04 13:43:00, M-A wrote:
> https://codereview.appspot.com/83380043/diff/1/upload.py
> File upload.py (right):
> 
> https://codereview.appspot.com/83380043/diff/1/upload.py#newcode2704
> upload.py:2704: "%(lineno)s %(message)s "))
> On 2014/04/04 01:30:03, agable1 wrote:
> > On 2014/04/02 17:20:55, M-A wrote:
> > > I think you have to put level=logging.DEBUG here to not break standalone
> > usage.
> > 
> > The default root logger logs with loglevel WARNING. And one or more -v flags
> > passed to this script standalone will still trigger the logic on line 2536.
> 
> Confirmed? If so, lgtm.

Confirmed -- running upload.py results in minimal output, running upload.py -v
results in INFO output, and running upload.py --noisy results in DEBUG output.
Going to commit + push this now.

[agable1, 2014-04-04 19:29:17]

On 2014/04/04 18:56:54, agable1 wrote:
> On 2014/04/04 13:43:00, M-A wrote:
> > https://codereview.appspot.com/83380043/diff/1/upload.py
> > File upload.py (right):
> > 
> > https://codereview.appspot.com/83380043/diff/1/upload.py#newcode2704
> > upload.py:2704: "%(lineno)s %(message)s "))
> > On 2014/04/04 01:30:03, agable1 wrote:
> > > On 2014/04/02 17:20:55, M-A wrote:
> > > > I think you have to put level=logging.DEBUG here to not break standalone
> > > usage.
> > > 
> > > The default root logger logs with loglevel WARNING. And one or more -v
flags
> > > passed to this script standalone will still trigger the logic on line
2536.
> > 
> > Confirmed? If so, lgtm.
> 
> Confirmed -- running upload.py results in minimal output, running upload.py -v
> results in INFO output, and running upload.py --noisy results in DEBUG output.
> Going to commit + push this now.

Landed as:
changeset:   1266:a98e723b83e4
tag:         tip
parent:      1241:2526390e1e13
user:        Aaron Gable <agable@chromium.org>
date:        Fri Apr 04 12:19:00 2014 -0700
summary:     Give upload.py a module-scope logger.

[agable1, 2014-04-04 19:35:29]

On 2014/04/04 19:29:17, agable1 wrote:
> On 2014/04/04 18:56:54, agable1 wrote:
> > On 2014/04/04 13:43:00, M-A wrote:
> > > https://codereview.appspot.com/83380043/diff/1/upload.py
> > > File upload.py (right):
> > > 
> > > https://codereview.appspot.com/83380043/diff/1/upload.py#newcode2704
> > > upload.py:2704: "%(lineno)s %(message)s "))
> > > On 2014/04/04 01:30:03, agable1 wrote:
> > > > On 2014/04/02 17:20:55, M-A wrote:
> > > > > I think you have to put level=logging.DEBUG here to not break
standalone
> > > > usage.
> > > > 
> > > > The default root logger logs with loglevel WARNING. And one or more -v
> flags
> > > > passed to this script standalone will still trigger the logic on line
> 2536.
> > > 
> > > Confirmed? If so, lgtm.
> > 
> > Confirmed -- running upload.py results in minimal output, running upload.py
-v
> > results in INFO output, and running upload.py --noisy results in DEBUG
output.
> > Going to commit + push this now.
> 
> Landed as:
> changeset:   1266:a98e723b83e4
> tag:         tip
> parent:      1241:2526390e1e13
> user:        Aaron Gable <mailto:agable@chromium.org>
> date:        Fri Apr 04 12:19:00 2014 -0700
> summary:     Give upload.py a module-scope logger.

Grafted to chromium branch as
changeset:   1267:d7b39eca7dbe
branch:      chromium
tag:         tip
parent:      1265:65c46b4bb192
user:        Aaron Gable <agable@chromium.org>
date:        Fri Apr 04 12:19:00 2014 -0700
summary:     Give upload.py a module-scope logger.